@Tom-Elliott updated and working - thanks for fixing!

@JJ-Fullmer You were correct about the download link not being formed properly. I went looking in the code and found a change in the /var/www/html/fog/lib/client/snapinclient.class.php file from a working version of FOG (1.6 beta 2132) to the latest version.

Copying over the old version of this file and snapins are installing correctly now.

@Tom-Elliott this should probably be moved to the Bug Reports forum if that’s possible? The difference in the files is the latest version is missing the below code around line 185

$location = sprintf(
  '%s://%s/%s',
   self::$httpproto,
   $StorageNode->get('ip'),
   $StorageNode->get('webroot')
);

and there are a few changes elsewhere too.

Thanks all!

@Tom-Elliott latest pull working correctly again. Thanks for sorting!

@Laurent we’re on FOG 1.6, but I think its the same as 1.5.10. FOG doesn’t let you see the AD password once input, but I’d echo @JJ-Fullmer’s point of using a specific account

@iljared98 this is what we do too.

@Laurent we’re on FOG 1.6, but I think its the same as 1.5.10. FOG doesn’t let you see the AD password once input, but I’d echo @JJ-Fullmer’s point of using a specific account

Do you get any error message in the FOG.log file in the root of C on a client?

@Tom-Elliott latest pull working correctly again. Thanks for sorting!

@Tom-Elliott updated to 2138 but now snapins not working. No http or https in the Communication download string. This is on the master FOG server, I haven’t updated the storage nodes yet.

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 18/10/2024 11:10:05 Client-Info Client Version: 0.13.0
 18/10/2024 11:10:05 Client-Info Client OS:      Windows
 18/10/2024 11:10:05 Client-Info Server Version: 1.6.0-beta.2138
 18/10/2024 11:10:05 Middleware::Response Success
 18/10/2024 11:10:05 SnapinClient Running snapin IPEvo-Visualiser
 18/10/2024 11:10:05 Middleware::Communication Download: ://10.16.46.84//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1711
 18/10/2024 11:10:05 Middleware::Communication ERROR: Could not download file
 18/10/2024 11:10:05 Middleware::Communication ERROR: Illegal characters in path.
 18/10/2024 11:10:05 SnapinClient C:\Program Files (x86)\FOG\tmp\Visualizer_win7-11_v3.6.0.1.msi
 18/10/2024 11:10:05 Middleware::Communication URL: http://10.16.46.84/fog/service/snapins.checkin.php?taskid=1711&exitcode=-1&mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&newService&json
------------------------------------------------------------------------------

Restoring the /var/www/html/fog/lib/client/snapinclient.class.php file from beta 2132 starts working again

@Tom-Elliott said in Snapins not deploying: Illegal characters in path.:

You use location plugin, correct?

Yes, that’s right.

I’ve pushed another fix that I think might help here and it takes a slightly different approach albeit similar.

Awesome, thanks. I’ll give it a try today

@JJ-Fullmer You were correct about the download link not being formed properly. I went looking in the code and found a change in the /var/www/html/fog/lib/client/snapinclient.class.php file from a working version of FOG (1.6 beta 2132) to the latest version.

Copying over the old version of this file and snapins are installing correctly now.

@Tom-Elliott this should probably be moved to the Bug Reports forum if that’s possible? The difference in the files is the latest version is missing the below code around line 185

$location = sprintf(
  '%s://%s/%s',
   self::$httpproto,
   $StorageNode->get('ip'),
   $StorageNode->get('webroot')
);

and there are a few changes elsewhere too.

Thanks all!

@JJ-Fullmer yes, that could be it. I’ve found a FOG.log from a few weeks ago that has http:// in the download link:

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 03/10/2024 11:22:15 Client-Info Client Version: 0.13.0
 03/10/2024 11:22:15 Client-Info Client OS:      Windows
 03/10/2024 11:22:15 Client-Info Server Version: 1.6.0-beta.2132
 03/10/2024 11:22:15 Middleware::Response Success
 03/10/2024 11:22:15 SnapinClient Running snapin LetterJoin Fonts - Little Mead
 03/10/2024 11:22:15 Middleware::Communication Download: http://10.xx.yy.zz//fog/service/snapins.file.php?mac=B4:B6:86:DF:3A:9B|92:32:4B:5B:31:DD|D2:32:4B:5B:31:DD|90:32:4B:5B:31:DE||90:32:4B:5B:31:DD&taskid=1618
 03/10/2024 11:22:38 SnapinClient C:\Program Files (x86)\FOG\tmp\f1k1w2x2z2.msi
 03/10/2024 11:22:38 Bus Emmiting message on channel: Notification
 03/10/2024 11:22:38 SnapinClient Starting snapin
 03/10/2024 11:22:40 SnapinClient Snapin finished
 03/10/2024 11:22:40 SnapinClient Return Code: 0
 03/10/2024 11:22:40 Bus Emmiting message on channel: Notification
 03/10/2024 11:22:40 Middleware::Communication URL: http://10.xx.yy.zz/fog/service/snapins.checkin.php?taskid=1618&exitcode=0&mac=B4:B6:86:DF:3A:9B|92:32:4B:5B:31:DD|D2:32:4B:5B:31:DD|90:32:4B:5B:31:DE||90:32:4B:5B:31:DD&newService&json
------------------------------------------------------------------------------

@JJ-Fullmer its happening on all snapins, but it tries the first one and then stops.

FOG.log for the snapin today:

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 17/10/2024 08:41:58 Client-Info Client Version: 0.13.0
 17/10/2024 08:41:58 Client-Info Client OS:      Windows
 17/10/2024 08:41:58 Client-Info Server Version: 1.6.0-beta.2135
 17/10/2024 08:41:58 Middleware::Response Success
 17/10/2024 08:41:58 SnapinClient Running snapin IPEvo-Visualiser
 17/10/2024 08:41:58 Middleware::Communication Download: ://10.xx.xx.xx//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1700
 17/10/2024 08:41:58 Middleware::Communication ERROR: Could not download file
 17/10/2024 08:41:58 Middleware::Communication ERROR: Illegal characters in path.
 17/10/2024 08:41:58 SnapinClient C:\Program Files (x86)\FOG\tmp\Visualizer_win7-11_v3.6.0.1.msi
 17/10/2024 08:41:59 Middleware::Communication URL: http://10.xx.xx.xx/fog/service/snapins.checkin.php?taskid=1700&exitcode=-1&mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&newService&json
------------------------------------------------------------------------------

The only things in the www-error.log:

[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 335
[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 340
[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 398
[17-Oct-2024 07:42:05 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 335