New client some snapins doesn't work, ok with legacy client

[Wayne Workman]

@Claude-Girard said:

“c:\windows\system32\cmd.exe” /C copy /Y "C:\Program Files (x86)\FOG\tmp\activ-licences-labview-mp206.txt "C:\tmp

I think space is missing before snapin arguments

To me, it looks like the space is just in the wrong spot. see the trailing space before the end-quote?

[Claude Girard]

@Wayne-Workman Yes, maybe.
But this command line is the one generated by new fog client.
I don’t know why this space is in bad place, but this command line, when executed in a terminal window, give an error.
with a space before C:\tmp, no more error.

[Sebastian Roth]

Looking at the source code I find that the spaces are set correct. Although I am not that good at C# code. Take a look yourself: https://github.com/FOGProject/fog-client/blob/dev/Modules/SnapinClient/SnapinClient.cs#L177

[Joe Schmitt]

@Claude-Girard
This is a bug that is fixed in my nightly builds (as seen by @Uncle-Frank 's link). For now you should be able to add a space infront of
“C:\tmp” in your “Snapin Arguments” field. Hopefully that should serve as a hot-fix.

[Claude Girard]

@Jbob said:

@Claude-Girard
This is a bug that is fixed in my nightly builds (as seen by @Uncle-Frank 's link). For now you should be able to add a space infront of
“C:\tmp” in your “Snapin Arguments” field. Hopefully that should serve as a hot-fix.

I have already tried to add space before argument, but it is ignored, maybe because of html interpretation ?

[Tom Elliott]

I have to double check, but I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers. I won’t solve this until I am certain. This does not mean all bad entries from before will automatically work, but it should be fixed after updating.

[Claude Girard]

@Tom-Elliott said:

I have to double check, but I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers. I won’t solve this until I am certain. This does not mean all bad entries from before will automatically work, but it should be fixed after updating.

Hi Tom

I think it isn’t solved.
I don’t know if it’s like in:
https://forums.fogproject.org/topic/5931/rev-4932-snapins-parameters-with-in-command-not-correct-in-database/9

But in advanced pxe menu, when I write what you can see in screen captures, escape characters and accentued french characters are badly saved in database tables.

I think all these symptoms are linked, and caused by bad locales ? (my server is UTF8) or by escaped characters interpreted by PHP ?

Thanks again for your work.
Screen captures are from rev 5273

In FOG Gui:

In database:

[Claude Girard]

Bad screen capture in previous post

In database:

[Tom Elliott]

@Claude-Girard what’s the advanced file actually show? Does it display with the escaped code, or as the actual characters.

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard what’s the advanced file actually show? Does it display with the escaped code, or as the actual characters.

As you can see, && become &amp&amp in database, d’ become d&#039

If I modify directly in database and save it, in FOG Gui all seems ok, characters are ok.

But if I save PXE Menu from Gui, after that in database characters are with escaped code again

[Tom Elliott]

@Claude-Girard I’m still confused. What does the advanced menu have to do with snapins?

[Tom Elliott]

@Claude-Girard Beyond that, what does the advanced menu show when you go to it in browser?

http://ip.of.fog.srv/fog/service/ipxe/advanced.php

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard I’m still confused. What does the advanced menu have to do with snapins?

Nothing to do with snapins, but I understood when you reopened issue, that it was a similar problem than :
https://forums.fogproject.org/topic/5931/rev-4932-snapins-parameters-with-in-command-not-correct-in-database/9

Maybe I am wrong but isn’t it the same problem when you say:
“I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers.”

[Tom Elliott]

@Claude-Girard I found and believe I have fixed the issue (for all items fingers crossed).

I just pushed it to the wild too.

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard Beyond that, what does the advanced menu show when you go to it in browser?

http://ip.of.fog.srv/fog/service/ipxe/advanced.php

It shows escaped codes

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard I found and believe I have fixed the issue (for all items fingers crossed).

I just pushed it to the wild too.

Thank you and sorry for confusing you, maybe my english is too bad

[Tom Elliott]

I wasn’t confused about the language, I was confused what Advanced menu had to do with snapins, but ultimately it didn’t matter really. I understood what you were getting at and I was able to make the corrects to ensure things operated properly. Hopefully it’s much better for all things.

[Claude Girard]

@Tom-Elliott said:

I wasn’t confused about the language, I was confused what Advanced menu had to do with snapins, but ultimately it didn’t matter really. I understood what you were getting at and I was able to make the corrects to ensure things operated properly. Hopefully it’s much better for all things.

Yes but better english = better explanations !!!
Did you push these corrects on github ?
I just upgraded rev 5283 and i don’t notice any change.

[Joe Schmitt]

@Claude-Girard v0.9.6 is released, and this includes the snapin fix for the problem you originally posted on. (https://news.fogproject.org/client-v0-9-6/ )

[Claude Girard]

@Jbob said:

@Claude-Girard v0.9.6 is released, and this includes the snapin fix for the problem you originally posted on. (https://news.fogproject.org/client-v0-9-6/ )

Thank you.
I just tested and for me it’s ok.
You can mark this thread solved, but I will open a new one for the others problems, discussed with Tom, they are’nt solved.
And I found a snapin bug again, but not due to client.

Thanks again