New client some snapins doesn't work, ok with legacy client

[Claude Girard]

Hi,

Rev 4586 and last client.
But problem exist from previous rev, with client 0.9.4

I have some snapins that copy files in directory like the one in screen capture joined.
With new client, file is not copied.
In log, snapin run and seems ok, but no file in target directory.
With legacy client, file is copied.

For others snapins, like executables, or other command line tasks, it’s ok with new client.
Problem only for copy

[Joe Schmitt]

I will attempt to replicate your issue and get back to you.

[Wayne Workman]

I think this feature would help your issue…

https://forums.fogproject.org/topic/5751/snapin-show-command-during-editing/1

Give that thread some love.

[Claude Girard]

@Wayne-Workman said:

I think this feature would help your issue…

https://forums.fogproject.org/topic/5751/snapin-show-command-during-editing/1

Give that thread some love.

Yes it could help.
This feature is in rev 4738
Command seems to be correct.
On client, I can see the file appear in tmp directory under fog install directory, and disappear after snapin execution, but no copy in my target directory

[Joe Schmitt]

I cannot replicate this issue. I’ve replicated your snapin configuration and it works fine. According to the log you posted, the issue is with a configuration on your computer, not the client (the return Code 1). Try running the command on the machine manually (using a local copy of your license.dat file).

[Claude Girard]

@Jbob said:

I cannot replicate this issue. I’ve replicated your snapin configuration and it works fine. According to the log you posted, the issue is with a configuration on your computer, not the client (the return Code 1). Try running the command on the machine manually (using a local copy of your license.dat file).

Yes manually it works.
And remember, I said that after uninstall new client and install legacy one, it works.
I’ll try debug utility, to see if I can find more informations.
I don’t know if it can help, but client is installed on Win 8.1, with French parameters (but I have no accented characters in files or directory names)

[Claude Girard]

@Jbob Sorry but another Fog user confirmed that no file is copied.
After capturing processes on clients, I think I have found what is causing the issue.
Here is the command line executed on client:

“c:\windows\system32\cmd.exe” /C copy /Y "C:\Program Files (x86)\FOG\tmp\activ-licences-labview-mp206.txt "C:\tmp

I think space is missing before snapin arguments

[Wayne Workman]

@Claude-Girard said:

“c:\windows\system32\cmd.exe” /C copy /Y "C:\Program Files (x86)\FOG\tmp\activ-licences-labview-mp206.txt "C:\tmp

I think space is missing before snapin arguments

To me, it looks like the space is just in the wrong spot. see the trailing space before the end-quote?

[Claude Girard]

@Wayne-Workman Yes, maybe.
But this command line is the one generated by new fog client.
I don’t know why this space is in bad place, but this command line, when executed in a terminal window, give an error.
with a space before C:\tmp, no more error.

[Sebastian Roth]

Looking at the source code I find that the spaces are set correct. Although I am not that good at C# code. Take a look yourself: https://github.com/FOGProject/fog-client/blob/dev/Modules/SnapinClient/SnapinClient.cs#L177

[Joe Schmitt]

@Claude-Girard
This is a bug that is fixed in my nightly builds (as seen by @Uncle-Frank 's link). For now you should be able to add a space infront of
“C:\tmp” in your “Snapin Arguments” field. Hopefully that should serve as a hot-fix.

[Claude Girard]

@Jbob said:

@Claude-Girard
This is a bug that is fixed in my nightly builds (as seen by @Uncle-Frank 's link). For now you should be able to add a space infront of
“C:\tmp” in your “Snapin Arguments” field. Hopefully that should serve as a hot-fix.

I have already tried to add space before argument, but it is ignored, maybe because of html interpretation ?

[Tom Elliott]

I have to double check, but I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers. I won’t solve this until I am certain. This does not mean all bad entries from before will automatically work, but it should be fixed after updating.

[Claude Girard]

@Tom-Elliott said:

I have to double check, but I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers. I won’t solve this until I am certain. This does not mean all bad entries from before will automatically work, but it should be fixed after updating.

Hi Tom

I think it isn’t solved.
I don’t know if it’s like in:
https://forums.fogproject.org/topic/5931/rev-4932-snapins-parameters-with-in-command-not-correct-in-database/9

But in advanced pxe menu, when I write what you can see in screen captures, escape characters and accentued french characters are badly saved in database tables.

I think all these symptoms are linked, and caused by bad locales ? (my server is UTF8) or by escaped characters interpreted by PHP ?

Thanks again for your work.
Screen captures are from rev 5273

In FOG Gui:

In database:

[Claude Girard]

Bad screen capture in previous post

In database:

[Tom Elliott]

@Claude-Girard what’s the advanced file actually show? Does it display with the escaped code, or as the actual characters.

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard what’s the advanced file actually show? Does it display with the escaped code, or as the actual characters.

As you can see, && become &amp&amp in database, d’ become d&#039

If I modify directly in database and save it, in FOG Gui all seems ok, characters are ok.

But if I save PXE Menu from Gui, after that in database characters are with escaped code again

[Tom Elliott]

@Claude-Girard I’m still confused. What does the advanced menu have to do with snapins?

[Tom Elliott]

@Claude-Girard Beyond that, what does the advanced menu show when you go to it in browser?

http://ip.of.fog.srv/fog/service/ipxe/advanced.php

[Claude Girard]

@Tom-Elliott said:

@Claude-Girard I’m still confused. What does the advanced menu have to do with snapins?

Nothing to do with snapins, but I understood when you reopened issue, that it was a similar problem than :
https://forums.fogproject.org/topic/5931/rev-4932-snapins-parameters-with-in-command-not-correct-in-database/9

Maybe I am wrong but isn’t it the same problem when you say:
“I’m pretty sure I added the same type of code sanitization to the run with, file, run with args fields as I do with printers.”