Group Service settings not applying, sort of...

JJ Fullmer

Server

Version: 46/5956 (RC11 branch)
OS: Cent OS 7

Client

Version: 0.11.5
OS: Win 10 LTSB

Description

When I go to a group and go to adjust the service settings to enable all the features for example I see a few default options set as shown here.

I click the select all button and hit update and get a confirmation that it updated and it goes back to the default selections.

I then go check some of the hosts in that group and find that only those original 4 default options are selected on every host’s service settings. If I manually update the service settings on the host level it updates successfully.

Tom Elliott

Found the issue and it appears to be related to some rc11 changes to how inserts happen. There was a minor mistake on my part in that I wasn’t cleaning up a variable that desperately needed it, but this issue would have still happened just to how the query is passed. To prevent the issues specifically to module updates from groups, for now, I’ve made the insert occur in 500 item chunks, though I will likely do this for the method as a whole as mass inserting can be problematic if you just dump a ton of data anyway. The largest of these happens to be service settings and probably the only thing to notice these issues any way.

JJ Fullmer

After further testing realized this only happens on larger groups. It worked on groups of 8 and 18 members, but it does happen on a group with 160 members.

JJ Fullmer

@Senior-Developers Updated and tried it again. Still broken.

Tom Elliott

@JJ-Fullmer please check the groupMembers table. I have. Suspicion of 0 host ids somewhere

Tom Elliott

Or group ids

JJ Fullmer

@Tom-Elliott 0 host id’s?
So like go into command line and search for host id’s with 0 in the id?

Tom Elliott

@JJ-Fullmer On the groupMembers table yes

JJ Fullmer

@Tom-Elliott

MariaDB [fog]> select * from groupMembers;
+------+----------+-----------+
| gmID | gmHostID | gmGroupID |
+------+----------+-----------+
|    1 |       17 |        10 |
|  100 |     1493 |         3 |
|   72 |      128 |        15 |
|    4 |      153 |        13 |
|    5 |      154 |        13 |
|    6 |       42 |         5 |
|    7 |       93 |         4 |
|    8 |        9 |         4 |
|    9 |      126 |        15 |
|   10 |      155 |        13 |
|   11 |      129 |        15 |
|   12 |      156 |        11 |
|   13 |      157 |        11 |
|   79 |      448 |        16 |
|   78 |       69 |        16 |
|   16 |      151 |        11 |
|   17 |      152 |        11 |
|   18 |      158 |        11 |
|   19 |      150 |        11 |
|   20 |      280 |        11 |
|   21 |      302 |        11 |
|   22 |      317 |         3 |
|   77 |      395 |        16 |
|   76 |      197 |        16 |
|   75 |     1458 |        16 |
|   26 |      145 |         7 |
|   27 |      107 |         7 |
|   28 |     1062 |         3 |
|   29 |     1062 |         7 |
|   30 |     1456 |         3 |
|   31 |       34 |         3 |
|   32 |       34 |         7 |
|   33 |     1457 |         3 |
|   34 |     1457 |        12 |
|   35 |      135 |         3 |
|   36 |      135 |         1 |
|   37 |     1458 |         3 |
|   74 |      358 |        16 |
|   73 |      143 |        16 |
|   40 |       89 |         3 |
|   41 |       89 |         6 |
|   42 |     1459 |         2 |
|   43 |     1459 |         3 |
|   44 |      106 |         3 |
|   45 |      106 |        15 |
|   49 |     1463 |         3 |
|   47 |     1461 |         3 |
|   50 |     1464 |         3 |
|   51 |     1465 |         3 |
|   52 |       48 |         3 |
|   53 |       48 |         5 |
|   54 |      139 |         3 |
|   55 |      139 |         5 |
|   56 |       98 |         3 |
|   57 |       98 |        15 |
|   59 |       10 |        15 |
|   60 |       29 |        10 |
|   61 |       21 |        10 |
|   62 |      113 |        10 |
|   63 |       31 |        10 |
|   64 |       94 |        10 |
|   99 |     1492 |        10 |
|   66 |      112 |        10 |
|  107 |       82 |         3 |
|   68 |       28 |        10 |
|   69 |       15 |         3 |
|   70 |     1470 |        11 |
|   81 |     1475 |        11 |
|   80 |     1473 |        11 |
|   82 |     1476 |        11 |
|   83 |     1477 |        11 |
|   84 |     1478 |        11 |
|   85 |     1479 |        11 |
|   86 |     1480 |        11 |
|   87 |     1481 |        11 |
|   88 |     1482 |        16 |
|   89 |     1474 |        11 |
|   94 |     1488 |         3 |
|   95 |     1488 |        10 |
|   96 |        7 |        13 |
|   97 |        7 |         3 |
|   98 |      140 |         8 |
|  101 |     1493 |        10 |
|  102 |     1494 |         3 |
|  103 |     1494 |        10 |
|  104 |       97 |         3 |
|  105 |       97 |         7 |
|  108 |       82 |         5 |
|  109 |       83 |         3 |
|  110 |       14 |         3 |
|  111 |       26 |         3 |
|  112 |      138 |         3 |
|  113 |       78 |         3 |
|  114 |       77 |         3 |
|  115 |       32 |         3 |
|  116 |     1485 |         3 |
|  117 |      147 |         3 |
|  118 |     1467 |         3 |
|  119 |     1466 |         3 |
|  120 |     1490 |         3 |
|  121 |     1495 |         3 |
|  122 |       10 |         3 |
|  123 |     1469 |         3 |
|  124 |      109 |         3 |
|  125 |       36 |         3 |
|  126 |      101 |         3 |
|  127 |       11 |         3 |
|  128 |      144 |         3 |
|  129 |      110 |         3 |
|  130 |       33 |         3 |
|  131 |     1468 |         3 |
|  132 |        6 |         3 |
|  133 |      155 |         3 |
|  134 |      154 |         3 |
|  135 |      153 |         3 |
|  136 |       57 |         3 |
|  137 |       44 |         3 |
|  138 |      107 |         3 |
|  139 |      143 |         3 |
|  140 |      151 |         3 |
|  141 |      156 |         3 |
|  142 |      152 |         3 |
|  143 |      158 |         3 |
|  144 |      157 |         3 |
|  145 |      150 |         3 |
|  146 |     1470 |         3 |
|  147 |       85 |         3 |
|  148 |       76 |         3 |
|  149 |       72 |         3 |
|  150 |      130 |         3 |
|  151 |      137 |         3 |
|  152 |       16 |         3 |
|  153 |       86 |         3 |
|  154 |       91 |         3 |
|  155 |       42 |         3 |
|  156 |      358 |         3 |
|  157 |      141 |         3 |
|  158 |      100 |         3 |
|  159 |      302 |         3 |
|  160 |     1477 |         3 |
|  161 |     1478 |         3 |
|  162 |     1479 |         3 |
|  163 |       65 |         3 |
|  164 |       93 |         3 |
|  165 |        9 |         3 |
|  166 |       20 |         3 |
|  167 |       19 |         3 |
|  168 |       92 |         3 |
|  169 |      108 |         3 |
|  170 |      142 |         3 |
|  171 |      124 |         3 |
|  172 |      127 |         3 |
|  173 |       50 |         3 |
|  174 |     1489 |         3 |
|  175 |       24 |         3 |
|  176 |      125 |         3 |
|  177 |      102 |         3 |
|  178 |      118 |         3 |
|  179 |       41 |         3 |
|  180 |      132 |         3 |
|  181 |      103 |         3 |
|  182 |       22 |         3 |
|  183 |       35 |         3 |
|  184 |       80 |         3 |
|  185 |       84 |         3 |
|  186 |      136 |         3 |
|  187 |       27 |         3 |
|  188 |       18 |         3 |
|  189 |      280 |         3 |
|  190 |       66 |         3 |
|  191 |       95 |         3 |
|  192 |     1472 |         3 |
|  193 |      133 |         3 |
|  194 |       51 |         3 |
|  195 |       96 |         3 |
|  196 |       47 |         3 |
|  197 |      197 |         3 |
|  198 |     1481 |         3 |
|  199 |     1480 |         3 |
|  200 |      120 |         3 |
|  201 |      111 |         3 |
|  202 |      395 |         3 |
|  203 |      105 |         3 |
|  204 |     1482 |         3 |
|  205 |      140 |         3 |
|  206 |      131 |         3 |
|  207 |       25 |         3 |
|  208 |       17 |         3 |
|  209 |       69 |         3 |
|  210 |      145 |         3 |
|  211 |     1474 |         3 |
|  212 |     1473 |         3 |
|  213 |     1476 |         3 |
|  214 |     1475 |         3 |
|  215 |      104 |         3 |
|  216 |      448 |         3 |
|  217 |      134 |         3 |
|  218 |       43 |         3 |
|  219 |      121 |         3 |
|  220 |       13 |         3 |
|  221 |     1492 |         3 |
|  222 |      112 |         3 |
|  223 |       21 |         3 |
|  224 |       28 |         3 |
|  225 |     1491 |         3 |
|  226 |       31 |         3 |
|  227 |      128 |         3 |
|  228 |       94 |         3 |
|  229 |      113 |         3 |
|  230 |       29 |         3 |
|  231 |      119 |         3 |
|  232 |       12 |         3 |
|  233 |      122 |         3 |
|  234 |      116 |         3 |
|  235 |       37 |         3 |
|  236 |      129 |         3 |
|  237 |      126 |         3 |
|  238 |       64 |         3 |
|  239 |       79 |         3 |
|  240 |       90 |         3 |
|  241 |       88 |         3 |
|  242 |      108 |         6 |
|  243 |      142 |         6 |
|  244 |      124 |         6 |
|  245 |      127 |         6 |
|  246 |       50 |         6 |
|  247 |      147 |        17 |
|  259 |      110 |        13 |
|  249 |     1466 |        17 |
|  250 |     1490 |        17 |
|  251 |     1495 |        17 |
|  252 |       10 |        17 |
|  253 |     1469 |        17 |
|  254 |      109 |        17 |
|  255 |     1496 |         3 |
|  256 |     1496 |         9 |
|  257 |     1497 |         3 |
|  258 |     1497 |         6 |
|  260 |       33 |        13 |
|  261 |     1468 |        13 |
|  262 |        6 |        13 |
|  263 |      105 |        13 |
|  264 |     1498 |        10 |
|  265 |     1498 |         3 |
+------+----------+-----------+
244 rows in set (0.00 sec)

MariaDB [fog]> select * from groupMembers where gmHostID=0;
Empty set (0.00 sec)

MariaDB [fog]> select * from groupMembers where gmID=0;
Empty set (0.00 sec)

MariaDB [fog]> select * from groupMembers where gmGroupID=0;
Empty set (0.00 sec)

JJ Fullmer

@Tom-Elliott

MariaDB [fog]> select * from groupMembers where gmHostID not in (select hostID from hosts);
Empty set (0.00 sec)

Wayne Workman

I never understood why hosts can’t have a zero for their ID.

Tom Elliott

Found the issue and it appears to be related to some rc11 changes to how inserts happen. There was a minor mistake on my part in that I wasn’t cleaning up a variable that desperately needed it, but this issue would have still happened just to how the query is passed. To prevent the issues specifically to module updates from groups, for now, I’ve made the insert occur in 500 item chunks, though I will likely do this for the method as a whole as mass inserting can be problematic if you just dump a ton of data anyway. The largest of these happens to be service settings and probably the only thing to notice these issues any way.

Tom Elliott

@Wayne-Workman it isn’t a valid ‘real’ auto increment number in SQL, therefore the only way to get a 0 is a bad call or manually define it.

JJ Fullmer

@Tom-Elliott Updated and confirmed working

Group Service settings not applying, sort of...

Server

Client

Description

236

11.6k

17.1k

154.5k