Snapins not deploying: Illegal characters in path.

[sideone]

We’re on FOG 1.6.0-beta.2134 with multiple storage nodes. Snapins are no longer being deployed correctly.

Error happens on master and storage nodes, snapin has replicated to all nodes successfully.

Error from client is:

SnapinClient---------------------------------
------------------------------------------------------------------------------
 16/10/2024 08:17:55 Client-Info Client Version: 0.13.0
 16/10/2024 08:17:55 Client-Info Client OS:      Windows
 16/10/2024 08:17:55 Client-Info Server Version: 1.6.0-beta.2134
 16/10/2024 08:17:55 Middleware::Response Success
 16/10/2024 08:17:55 SnapinClient Running snapin LetterJoinFonts - BLC
 16/10/2024 08:17:55 Middleware::Communication Download: ://10.xx.xxx.xx//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1698
 16/10/2024 08:17:55 Middleware::Communication ERROR: Could not download file
 16/10/2024 08:17:55 Middleware::Communication ERROR: Illegal characters in path.
 16/10/2024 08:17:55 SnapinClient C:\Program Files (x86)\FOG\tmp\LetterJoinBLC.msi
 16/10/2024 08:17:55 Middleware::Communication URL: http://10.YY.yyy.yyy/fog/service/snapins.checkin.php?taskid=1698&exitcode=-1&mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&newService&json

Not sure if its relevant, but the task ID listed above is different to the task ID shown in the History Report.

[Tom Elliott]

@sideone If you’re willing to try the latest pull?

I’m trying to do it while having the new features of location plugin that were added in dev-branch. I apologize for the many iterations, but I think it should work now as I have failsafes in place too now.

[JJ Fullmer]

@sideone Is this happening on all snapins or just this one?
Any errors around the same time in /var/log/php-fpm/www-error.log ?
Can we see a screenshot of this snapins config in the gui? Maybe there’s something there.
The taskid bit is odd

[sideone]

@JJ-Fullmer its happening on all snapins, but it tries the first one and then stops.

FOG.log for the snapin today:

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 17/10/2024 08:41:58 Client-Info Client Version: 0.13.0
 17/10/2024 08:41:58 Client-Info Client OS:      Windows
 17/10/2024 08:41:58 Client-Info Server Version: 1.6.0-beta.2135
 17/10/2024 08:41:58 Middleware::Response Success
 17/10/2024 08:41:58 SnapinClient Running snapin IPEvo-Visualiser
 17/10/2024 08:41:58 Middleware::Communication Download: ://10.xx.xx.xx//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1700
 17/10/2024 08:41:58 Middleware::Communication ERROR: Could not download file
 17/10/2024 08:41:58 Middleware::Communication ERROR: Illegal characters in path.
 17/10/2024 08:41:58 SnapinClient C:\Program Files (x86)\FOG\tmp\Visualizer_win7-11_v3.6.0.1.msi
 17/10/2024 08:41:59 Middleware::Communication URL: http://10.xx.xx.xx/fog/service/snapins.checkin.php?taskid=1700&exitcode=-1&mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&newService&json
------------------------------------------------------------------------------

The only things in the www-error.log:

[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 335
[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 340
[17-Oct-2024 07:41:24 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 398
[17-Oct-2024 07:42:05 UTC] PHP Warning:  Undefined array key "menuAccess" in /var/www/html/fog/lib/fog/bootmenu.class.php on line 335

[sideone]

[JJ Fullmer]

@sideone So the taskid increment is normal, that’s the id of that specific task.

I just tested a snapin on my server which is on the same version of 1.6.0 and didn’t have the issue. But I did notice something glaring

17/10/2024 08:41:58 Middleware::Communication Download: ://10.xx.xx.xx//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1700

The download url is missing http or https

So we need to work out why that’s happening.

[sideone]

@JJ-Fullmer yes, that could be it. I’ve found a FOG.log from a few weeks ago that has http:// in the download link:

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 03/10/2024 11:22:15 Client-Info Client Version: 0.13.0
 03/10/2024 11:22:15 Client-Info Client OS:      Windows
 03/10/2024 11:22:15 Client-Info Server Version: 1.6.0-beta.2132
 03/10/2024 11:22:15 Middleware::Response Success
 03/10/2024 11:22:15 SnapinClient Running snapin LetterJoin Fonts - Little Mead
 03/10/2024 11:22:15 Middleware::Communication Download: http://10.xx.yy.zz//fog/service/snapins.file.php?mac=B4:B6:86:DF:3A:9B|92:32:4B:5B:31:DD|D2:32:4B:5B:31:DD|90:32:4B:5B:31:DE||90:32:4B:5B:31:DD&taskid=1618
 03/10/2024 11:22:38 SnapinClient C:\Program Files (x86)\FOG\tmp\f1k1w2x2z2.msi
 03/10/2024 11:22:38 Bus Emmiting message on channel: Notification
 03/10/2024 11:22:38 SnapinClient Starting snapin
 03/10/2024 11:22:40 SnapinClient Snapin finished
 03/10/2024 11:22:40 SnapinClient Return Code: 0
 03/10/2024 11:22:40 Bus Emmiting message on channel: Notification
 03/10/2024 11:22:40 Middleware::Communication URL: http://10.xx.yy.zz/fog/service/snapins.checkin.php?taskid=1618&exitcode=0&mac=B4:B6:86:DF:3A:9B|92:32:4B:5B:31:DD|D2:32:4B:5B:31:DD|90:32:4B:5B:31:DE||90:32:4B:5B:31:DD&newService&json
------------------------------------------------------------------------------

[JJ Fullmer]

@sideone Are you getting different IP addresses in the snapin download url and the communication url? i.e. is the communication URL going to your master and the download going to a storage node? Maybe a storage node has something goofy in its storage node config?

The communication url is derived from the c:\program files (X86)\Fog\settings.json file where it uses the Https flag, server name, and webroot values to construct that base url i.e. http://10.xx.xx.xx/fog
I’m not sure if the download url is combo of the settings.json file with info from the server or if it’s just from the server or what. But your download url is missing the http/https and is also has an extra slash.

P.S. you don’t really need to hide the ip of the fog server. It’s an internal subnet only ip address, it doesn’t expose anything to say what ip you’re using. Do whatever makes you feel safe, just saying is all.

[sideone]

@JJ-Fullmer You were correct about the download link not being formed properly. I went looking in the code and found a change in the /var/www/html/fog/lib/client/snapinclient.class.php file from a working version of FOG (1.6 beta 2132) to the latest version.

Copying over the old version of this file and snapins are installing correctly now.

@Tom-Elliott this should probably be moved to the Bug Reports forum if that’s possible? The difference in the files is the latest version is missing the below code around line 185

$location = sprintf(
  '%s://%s/%s',
   self::$httpproto,
   $StorageNode->get('ip'),
   $StorageNode->get('webroot')
);

and there are a few changes elsewhere too.

Thanks all!

[Tom Elliott]

@sideone You use location plugin, correct?

[Tom Elliott]

@sideone I’ve pushed another fix that I think might help here and it takes a slightly different approach albeit similar.

[sideone]

@Tom-Elliott said in Snapins not deploying: Illegal characters in path.:

You use location plugin, correct?

Yes, that’s right.

I’ve pushed another fix that I think might help here and it takes a slightly different approach albeit similar.

Awesome, thanks. I’ll give it a try today

[sideone]

@Tom-Elliott updated to 2138 but now snapins not working. No http or https in the Communication download string. This is on the master FOG server, I haven’t updated the storage nodes yet.

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 18/10/2024 11:10:05 Client-Info Client Version: 0.13.0
 18/10/2024 11:10:05 Client-Info Client OS:      Windows
 18/10/2024 11:10:05 Client-Info Server Version: 1.6.0-beta.2138
 18/10/2024 11:10:05 Middleware::Response Success
 18/10/2024 11:10:05 SnapinClient Running snapin IPEvo-Visualiser
 18/10/2024 11:10:05 Middleware::Communication Download: ://10.16.46.84//fog/service/snapins.file.php?mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&taskid=1711
 18/10/2024 11:10:05 Middleware::Communication ERROR: Could not download file
 18/10/2024 11:10:05 Middleware::Communication ERROR: Illegal characters in path.
 18/10/2024 11:10:05 SnapinClient C:\Program Files (x86)\FOG\tmp\Visualizer_win7-11_v3.6.0.1.msi
 18/10/2024 11:10:05 Middleware::Communication URL: http://10.16.46.84/fog/service/snapins.checkin.php?taskid=1711&exitcode=-1&mac=0C:9D:92:C9:DE:33|0C:9D:92:C9:DE:32&newService&json
------------------------------------------------------------------------------

Restoring the /var/www/html/fog/lib/client/snapinclient.class.php file from beta 2132 starts working again

[Tom Elliott]

@sideone If you’re willing to try the latest pull?

I’m trying to do it while having the new features of location plugin that were added in dev-branch. I apologize for the many iterations, but I think it should work now as I have failsafes in place too now.

[sideone]

@Tom-Elliott latest pull working correctly again. Thanks for sorting!