Firefox 47 snap-in

[JoeG]

Running FOG 1.3-RC-1 on Ubuntu 14.04 LTS

Not sure if this is a FOG issue or a Firefox issue, but when deploying ‘Firefox Setup 47.0.1.exe’ or ‘Firefox Setup 47.0.exe’ to either Windows 7 x64 or Windows 10 as a snapin gives this error:

------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 7/20/2016 3:24 PM Client-Info Client Version: 0.11.4
 7/20/2016 3:24 PM Client-Info Client OS:      Windows
 7/20/2016 3:24 PM Client-Info Server Version: 1.3.0-RC-1
 7/20/2016 3:24 PM Middleware::Response Success
 7/20/2016 3:24 PM SnapinClient Snapin Found:
 7/20/2016 3:24 PM SnapinClient     ID: -1
 7/20/2016 3:24 PM SnapinClient     Name: 
 7/20/2016 3:24 PM SnapinClient     Created: -1
 7/20/2016 3:24 PM SnapinClient     Action: 
 7/20/2016 3:24 PM SnapinClient     Pack: False
 7/20/2016 3:24 PM SnapinClient     Hide: False
 7/20/2016 3:24 PM SnapinClient     Server: 
 7/20/2016 3:24 PM SnapinClient     TimeOut: -1
 7/20/2016 3:24 PM SnapinClient     RunWith: 
 7/20/2016 3:24 PM SnapinClient     RunWithArgs: 
 7/20/2016 3:24 PM SnapinClient     Args: 
 7/20/2016 3:24 PM SnapinClient     File: 
 7/20/2016 3:24 PM SnapinClient ERROR: Snapin hash does not exist
------------------------------------------------------------------------------

The snapin runs with the ‘-ms’ argument for silent install. Previous versions of FF were deployed as snapin with the same argument and without issue. Creating the snapin anew does not resolve. My next step is to roll back to a previous version, will share results.

Curious if anyone else has run into this error specifically with Firefox. Thanks,

Joe

[Tom Elliott]

I don’t think it’s specific to the software being installed.

I had one instance where the server returned a 500 code (syntax/issue with server), however I was not able to see what the error was.

[Tom Elliott]

On thought, can you try editing fogcontroller.class.php. This is found under /var/www/fog/lib/fog/fogcontroller.class.php.

Look for function isValid within this file.

You will likely see: if (!$this->get('id')) throw new Exception(_('Invalid ID'))

Change it to read as: if ($this->get('id') < 1) throw new Exception(_('Invalid ID'));

Hopefully this will prevent -1 identifiers.

[Wayne Workman]

We were having this issue today at work but on about a week old trunk version, afk right now.

It was a silent avast install, about 250MB. File uploads fine but we got the same error in the fog client log, with hashes not existing.

[JoeG]

@Tom-Elliott thanks for the suggestion. here is the isValid function from my /var/www/fog/lib/fog/FOGController.class.php. it doesn’t quite match what you wrote so I wanted to check with you before making changes. can you confirm the change i should make is on the if (!$this->get($field)) line?

        // isValid
        /** isValid()
                Checks that the returned items are valid for the relevant class calling it.
        */
        public function isValid()
        {
                try
                {
                        foreach ($this->databaseFieldsRequired AS $field)
                        {
                                if (!$this->get($field))
                                        throw new Exception(_('Required database field is empty'));
                        }
                        if ($this->get('id') || $this->get('name'))
                                return true;
                }
                catch (Exception $e)
                {
                        $this->debug('isValid Failed: Error: %s', array($e->getMessage()));
                }
                return false;
        }

Additionally, I created a new snapin for Firefox 45.0.2 and the original error persists. All other snapins are working, though…

Joe

[Tom Elliott]

@JoeG How is that even possible? Your client is showing you’re running 1.3.0-RC-1. However, the file you’re showing is from 1.2.0?

[JoeG]

@Tom-Elliott beats me! very strange. i renamed /var/www/…/FOGController.class.php to FOGController.class.php.backup and ran the FOG 1.3.0-RC-1 installer again but it left the file as is.

[JoeG]

@Tom-Elliott one other note, the snapins have the names “Firefox 47.0.1” and “Firefox 45” - include spaces and periods. do you think these characters are affecting deployment? as mentioned in this topic: https://forums.fogproject.org/topic/8136/1-3-0-rc-1-snapin-spaces

[Tom Elliott]

@JoeG Yes. Yes I do.

I have a fix for that which will be available in RC 2, but it will mean recreating the snapins (or reuploading the files).

For now, please upload the same files replacing the spaces with _. Make sure the Snapin file for that/those snapins are set to use the _ named files.

[JoeG]

@Tom-Elliott Success!! changing filename from “Firefox Setup 47.0.1.exe” to “Firefox47.exe” and renaming snapin to “Firefox47” allowed the snapin to deploy. many thanks for your help!