Disallow saving incorrect storage node credentials

[x23piracy]

Intercepting errors is always a good thing.

[Tom Elliott]

Sorry, this is too complex to add. While programmatically it’s easy, it’s not up to US to determine the viability and usability of a password.

We have set some “sane” defaults. For example, fog generates a random user’s password on installation. This password is relatively secure in that the password is randomly generated. This means the password is SET FOR THE USER. What the user does before or after this is complete is outside of the realm of FOG’s necessity. Let’s say you create the FOG user password P@33W0rd!, but you keep typing in P@33w0rd! does this mean fog should fail to create a node because of one letter? I don’t think so, it should be up to you, the user making the entry, to ensure the information is correct.

Somebody else wants to add in the checks for this, by all means, but this isn’t something I feel we should do for you. That’d be like trying to say we shouldn’t allow you to edit any facet of FOG simply because it’s too error prone.

[Tom Elliott]

I’ll add why I say this is not a good approach beyond what i just described.

What if you want to create your storage node before your node is actually setup? Yes, sometimes, people want to have things setup Before they’re ready to use. (For example, should we not allow manual creation of hosts because they didn’t go through the inventory or registration process? Should we make “capture” define the image during the capture process because only then do we know that the image will be usable and viable? Should we ping and test validity of printers when creating them and not allow them to be added if you cannot actually print to them?

[Joe Schmitt]

I could see us adding a warning if a node cannot connect. However, I am in agreement with @Tom-Elliott that straight up preventing credential entering would cause more issues than it would solve.

[Tom Elliott]

Something similar to?:

[Wayne Workman]

@tom-elliott That would be perfect, just to inform the user that something might be wrong.

[Tom Elliott]

I think this looks a little better, as it warns the user in a more appropriate fashion.

[george1421]

@tom-elliott If I can suggest here: The “storage node create success” is a bit confusing with a yellow/orange color. I might suggest “Storage Node Create Warning” if you are using the yellow/orange color to signal trouble ahead. Yes it was created successfully, but it didn’t work as expected is what I would interpreter the message and color to indicate. Then of course red sign would be everything failed.

[Wayne Workman]

Agree with George, “Storage Node Create Successful” is alone confusing. How about “Storage Node Created With Warnings”

[Tom Elliott]

@wayne-workman and @george1421 this has been added for 1.6. I’m not going to try adding it to 1.5 as it is a bit of work to add the tests and the return information is at best rudimentary in 1.5.