• Recent
  • Unsolved
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login
  • Recent
  • Unsolved
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login

Disallow saving incorrect storage node credentials

Scheduled Pinned Locked Moved
Feature Request
5
12
1.9k
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • W
    Wayne Workman
    last edited by Aug 1, 2016, 10:00 PM

    I think that credentials put into storage management for a node ought to be checked for validity. And if they are invalid, they shouldn’t be stored and a warning message displayed for why and what to do.

    Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!
    Daily Clean Installation Results:
    https://fogtesting.fogproject.us/
    FOG Reporting:
    https://fog-external-reporting-results.fogproject.us/

    1 Reply Last reply Reply Quote 1
    • W
      Wayne Workman
      last edited by May 9, 2018, 2:41 PM

      Bumping this.

      Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!
      Daily Clean Installation Results:
      https://fogtesting.fogproject.us/
      FOG Reporting:
      https://fog-external-reporting-results.fogproject.us/

      1 Reply Last reply Reply Quote 1
      • X
        x23piracy
        last edited by May 10, 2018, 9:17 PM

        Intercepting errors is always a good thing.

        ║▌║█║▌│║▌║▌█

        1 Reply Last reply Reply Quote 0
        • T
          Tom Elliott
          last edited by May 10, 2018, 10:58 PM

          Sorry, this is too complex to add. While programmatically it’s easy, it’s not up to US to determine the viability and usability of a password.

          We have set some “sane” defaults. For example, fog generates a random user’s password on installation. This password is relatively secure in that the password is randomly generated. This means the password is SET FOR THE USER. What the user does before or after this is complete is outside of the realm of FOG’s necessity. Let’s say you create the FOG user password P@33W0rd!, but you keep typing in P@33w0rd! does this mean fog should fail to create a node because of one letter? I don’t think so, it should be up to you, the user making the entry, to ensure the information is correct.

          Somebody else wants to add in the checks for this, by all means, but this isn’t something I feel we should do for you. That’d be like trying to say we shouldn’t allow you to edit any facet of FOG simply because it’s too error prone.

          Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

          Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

          Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

          1 Reply Last reply Reply Quote 1
          • T
            Tom Elliott
            last edited by Tom Elliott May 10, 2018, 5:06 PM May 10, 2018, 11:03 PM

            I’ll add why I say this is not a good approach beyond what i just described.

            What if you want to create your storage node before your node is actually setup? Yes, sometimes, people want to have things setup Before they’re ready to use. (For example, should we not allow manual creation of hosts because they didn’t go through the inventory or registration process? Should we make “capture” define the image during the capture process because only then do we know that the image will be usable and viable? Should we ping and test validity of printers when creating them and not allow them to be added if you cannot actually print to them?

            Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

            Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

            Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

            1 Reply Last reply Reply Quote 0
            • J
              Joe Schmitt Senior Developer
              last edited by Joe Schmitt May 10, 2018, 5:10 PM May 10, 2018, 11:09 PM

              I could see us adding a warning if a node cannot connect. However, I am in agreement with @Tom-Elliott that straight up preventing credential entering would cause more issues than it would solve.

              Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

              1 Reply Last reply Reply Quote 1
              • T
                Tom Elliott
                last edited by May 11, 2018, 12:10 AM

                Something similar to?:
                0_1525997414681_90ba1fe9-719c-4b1e-8017-a9458fab1042-image.png

                Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                W 1 Reply Last reply May 11, 2018, 2:27 PM Reply Quote 1
                • W
                  Wayne Workman @Tom Elliott
                  last edited by May 11, 2018, 2:27 PM

                  @tom-elliott That would be perfect, just to inform the user that something might be wrong.

                  Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!
                  Daily Clean Installation Results:
                  https://fogtesting.fogproject.us/
                  FOG Reporting:
                  https://fog-external-reporting-results.fogproject.us/

                  1 Reply Last reply Reply Quote 1
                  • T
                    Tom Elliott
                    last edited by May 12, 2018, 4:03 AM

                    I think this looks a little better, as it warns the user in a more appropriate fashion.
                    0_1526097790969_e714a9e5-f1e7-4cc3-94a9-ff8febae58d0-image.png

                    Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                    Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                    Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                    G 1 Reply Last reply May 12, 2018, 6:07 PM Reply Quote 1
                    • G
                      george1421 Moderator @Tom Elliott
                      last edited by May 12, 2018, 6:07 PM

                      @tom-elliott If I can suggest here: The “storage node create success” is a bit confusing with a yellow/orange color. I might suggest “Storage Node Create Warning” if you are using the yellow/orange color to signal trouble ahead. Yes it was created successfully, but it didn’t work as expected is what I would interpreter the message and color to indicate. Then of course red sign would be everything failed.

                      Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                      1 Reply Last reply Reply Quote 1
                      • W
                        Wayne Workman
                        last edited by May 14, 2018, 1:51 PM

                        Agree with George, “Storage Node Create Successful” is alone confusing. How about “Storage Node Created With Warnings”

                        Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!
                        Daily Clean Installation Results:
                        https://fogtesting.fogproject.us/
                        FOG Reporting:
                        https://fog-external-reporting-results.fogproject.us/

                        T 1 Reply Last reply Jun 1, 2018, 4:40 AM Reply Quote 0
                        • T
                          Tom Elliott @Wayne Workman
                          last edited by Jun 1, 2018, 4:40 AM

                          @wayne-workman and @george1421 this has been added for 1.6. I’m not going to try adding it to 1.5 as it is a bit of work to add the tests and the return information is at best rudimentary in 1.5.

                          Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                          Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                          Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                          1 Reply Last reply Reply Quote 3
                          • 1 / 1
                          • First post
                            Last post

                          235

                          Online

                          12.0k

                          Users

                          17.3k

                          Topics

                          155.2k

                          Posts
                          Copyright © 2012-2024 FOG Project