SVN-Update: Error in creating dhcpd.conf
-
@Wayne-Workman said:
ip addr show $interface | awk -F’[ /]’ ‘/([0-9][0-9]?[0-9]?.){3}([0-9][0-9]?[0-9]?){1}/ {print $6}’
Found a few issues with how the controls were in place and added elements to make corrections as needed. This should be fixed now.
-
Now it’s better - I still get the Info
* Setting up storage..........................................OK * Setting up and starting DHCP Server......................... !!! No router address found !!! !!! No dns address found !!! OK * Setting up and starting TFTP and PXE Servers................OK
but the script continues and everything seems to be ok.
-
@Oleg Can you please check to see if there is a Router/DNS address set inside of
/etc/dhcp/dhcpd.conf
? Also, what are the router and DNS values inside of/opt/fog/.fogsettings
now? -
@Wayne-Workman
yes in both files are the addresses set correctly -
@And if you re-run the installer, you should no longer get those messages
!!! No dns address found !!!
If you do not see those messages anymore, then this issue is resolved.
-
@Wayne-Workman I really don’t want to dissapoint you
I’ve updated now to the svn 6755 and still get the ! ! ! No router address found ! ! ! and ! ! ! No dns address found ! ! !
How I said before - the setup is complete and everything seems to work. I only get these two “warnings”Here is my .fogsettings:
## Start of FOG Settings ## Created by the FOG Installer ## Version: 6755 ## Install time: Sat 12 Mar 2016 05:58:49 PM CET ipaddress='192.168.94.111' interface='eth0' submask='255.255.255.0' routeraddress='192.168.94.1' plainrouter='192.168.94.1' dnsaddress='192.168.94.1' dnsbootimage='192.168.94.1' username='fog' password="XXXXXX" osid='2' osname='Debian' dodhcp='Y' bldhcp='1' blexports='1' installtype='N' snmysqluser='' snmysqlpass="" snmysqlhost='' installlang='' donate='0' storageLocation='/images' fogupdateloaded=1 docroot='/var/www/html/' webroot='fog/' caCreated='yes' startrange='192.168.94.60' endrange='192.168.94.99' bootfilename='undionly.kpxe' packages='apache2 php5 php5-json php5-gd.... noTftpBuild='' notpxedefaultfile='' sslpath='/opt/fog/snapins/ssl/' ## End of FOG Settings
And this is the dhcpd.conf:
... next-server 192.168.94.111; # Specify subnet of ether device you do NOT want service. # For systems with two or more ethernet devices. # subnet 136.165.0.0 netmask 255.255.0.0 {} subnet 192.168.94.0 netmask 255.255.255.0{ option subnet-mask 255.255.255.0; range dynamic-bootp 192.168.94.60 192.168.94.99; default-lease-time 21600; max-lease-time 43200; option routers 192.168.94.1; option domain-name-servers 192.168.94.1; ...
-
Confirmed, found, here is the fix:
diff --git a/lib/common/functions.sh b/lib/common/functions.sh index 5b3431d..15640c5 100755 --- a/lib/common/functions.sh +++ b/lib/common/functions.sh @@ -1834,8 +1834,8 @@ configureDHCP() { echo " max-lease-time 43200;" >> "$dhcptouse" [[ ! $(validip $routeraddress) -eq 0 ]] && routeraddress=$(echo $routeraddress | grep -oE "\b([0-9]{1,3}\.){3}[0-9]{1,3}\b") [[ ! $(validip $dnsaddress) -eq 0 ]] && dnsaddress=$(echo $dnsaddress | grep -oE "\b([0-9]{1,3}\.){3}[0-9]{1,3}\b") - [[ $(validip $routeraddress) -eq 0 ]] && echo " option routers $routeraddress;" >> "$dhcptouse" || echo " #option routers 0.0.0.0" >> "$dhcptouse" && echo " !!! No router address found !!!" - [[ $(validip $dnsaddress) -eq 0 ]] && echo " option domain-name-servers $dnsaddress;" >> "$dhcptouse" || echo " #option routers 0.0.0.0" >> "$dhcptouse" && echo " !!! No dns address found !!!" + [[ $(validip $routeraddress) -eq 0 ]] && echo " option routers $routeraddress;" >> "$dhcptouse" || ( echo " #option routers 0.0.0.0" >> "$dhcptouse" && echo " !!! No router address found !!!" ) + [[ $(validip $dnsaddress) -eq 0 ]] && echo " option domain-name-servers $dnsaddress;" >> "$dhcptouse" || ( echo " #option routers 0.0.0.0" >> "$dhcptouse" && echo " !!! No dns address found !!!" ) echo " class \"Legacy\" {" >> "$dhcptouse" echo " match if substring(option vendor-class-identifier, 0, 20) = \"PXEClient:Arch:00000\";" >> "$dhcptouse" echo " filename \"undionly.kkpxe\";" >> "$dhcptouse"
Sorry @Tom-Elliott for just posting this here but I don’t think this is worth a pull request…
-
@Sebastian-Roth That’s fine, but it doesn’t appear to have all the data.
-
Yeah, just noticed…updated my post. Essentially it’s just some brackets missing to make the logic work like it should
[[ ...]] && ... || ( ... && ...)
-
@Sebastian-Roth Added to the code and pushed.
-
@Oleg Can you please update and try again since there has been another fix to this? Ideally, you should no longer get the warnings.
-
Perfect now! Installer and configs are all correct. From my side the problem is solved. Thanks!