r6551 "Other" OSID

[Wayne Workman]

I took an image of Ubuntu and Windows 7 yesterday, I used the “Other” os type and made it a single disk - non-resizable. This morning I’m trying to restore but I’m getting an error.

Invalid operating system id: Windows (Other) (4) (validResizeOS)
Args Passed:

[Sebastian Roth]

@Tom-Elliott But I am still wondering why we do validResizeOS for MPS and RAW image in fog.download on line 38!

[Tom Elliott]

added hopeful code to address osid 4.

[Wayne Workman]

@Sebastian-Roth said:

Resizable didn’t work why? Error??

lol I’m sorry. I’ll reproduce sometime next week (don’t have a win7 image for this laptop at home, don’t wanna make one either lol).

[Sebastian Roth]

Resizable didn’t work why? Error?? But still our scripts check validResizeOS on deploy even for non-resizable… Don’t think this is wise.

[Wayne Workman]

@Sebastian-Roth My first attempt was “Other” with “single disk - resizable” but that didn’t work. I didn’t sweat it too much because of what I was asking.

[Sebastian Roth]

Where is d1p6.img??

[Wayne Workman]

ls -laht

total 33G
drwxrwxrwx. 10 fog  root  245 Mar  4 22:30 ..
-rwxrwxrwx.  1 root root   47 Mar  4 17:49 d1.original.swapuuids
drwxrwxrwx.  2 root root  185 Mar  4 17:49 .
-rwxrwxrwx.  1 root root 7.2G Mar  4 17:49 d1p5.img
-rwxrwxrwx.  1 root root  512 Mar  4 17:41 d1p3.ebr
-rwxrwxrwx.  1 root root  26G Mar  4 17:41 d1p2.img
-rwxrwxrwx.  1 root root 8.2M Mar  4 17:13 d1p1.img
-rwxrwxrwx.  1 root root  512 Mar  4 17:13 d1p6.ebr
-rwxrwxrwx.  1 root root  512 Mar  4 17:13 d1p5.ebr
-rwxrwxrwx.  1 root root  366 Mar  4 17:13 d1.partitions
-rwxrwxrwx.  1 root root 1.0M Mar  4 17:13 d1.mbr
-rwxrwxrwx.  1 root root    0 Mar  4 17:13 d1.has_grub

cat d1.partitions

label: dos
label-id: 0x2bd2c32a
device: /dev/sda
unit: sectors

/dev/sda1 : start=        2048, size=      204800, type=7, bootable
/dev/sda2 : start=      206848, size=   528649716, type=7
/dev/sda3 : start=   528857086, size=   447913986, type=5
/dev/sda5 : start=   528857088, size=   432007168, type=83
/dev/sda6 : start=   960866304, size=    15904768, type=82

[Sebastian Roth]

Good catch! We can add osid 4 to the validResizeOS check easily but I wonder why it is called in fog.download for single disk - non-resizable on line 38 at all. Should only be called for resizable I reckon.