Problem updating to 1.5.10

[pep]

"I had a problem when updating to 1.5.10. The update process went well until it requested to update the database, then the website was unresponsive while the Apache server was running. I observed the following error in the httpd logs (ssl_error_log):

[php7:error] [pid 31427] [client “ip”:60433] PHP Parse error: syntax error, unexpected ‘)’ in /var/www/html/fog/lib/plugins/location/pages/locationmanagementpage.class.php on line 170

I removed the comma from line 169, after the $protocol variable in the locationmanagementpage.class.php file, and then the update process completed successfully. I’m currently testing image deployment and it seems to be working. What happened is that all default services like ‘power manager’, ‘printer manager’, ‘snapins’, etc. were disabled on the computers, and I can enable them one by one. Once enabled, the computers were successfully added to the domain, but I still can’t send snapins; the fog.txt file shows an error that it can’t download the file. I’ve decided to roll back the update and investigate further. I’ll try to document it better, but it seems like a problem with the location plugin."

php 7.2.34
centos 7.9

pd: I edit, it’s not downloading the snapin because the “http” is missing in the link. I assume it’s due to the variable $protocol that I modified on line 169

[Sebastian Roth]

@pep On first sight this sounds like this is a last minute bug introduced when trying to fix a location snapin issue (commit b33e4d9).

Will work on fixing that in dev-branch soon!

I edit, it’s not downloading the snapin because the “http” is missing in the link. I assume it’s due to the variable $protocol that I modified on line 169

Too bad, probably because there is no default set on upgraded installs. ARGH

[pep]

@Sebastian-Roth ok, thanks

[Sebastian Roth]

@pep Finally found some time to properly document this issue on github.

Update issue: https://github.com/FOGProject/fogproject/issues/561
Snapin issue: https://github.com/FOGProject/fogproject/issues/562

Both should be fixed in latest dev-banch. The later still needs some good testing. I just did a very basic test to make sure the default schema is being applied.