working-1.6 branch installation issue: tftpd service not restarted

[Daniel Miller]

Newly installed and updated Ubuntu 18.04 box throws a couple of error messages during fog installation
From foginstall.log:

 * Setting up and starting TFTP Server.........................Too few arguments.
 Too few arguments.
 OK
 * Setting up and starting VSFTP Server........................OK

Results in TFTP daemon not restarted after configuration change. Running configuration points to directory /var/lib/tftpboot. Configuration is corrected on service or server restart.

Traced to functions.sh#L458-L459

                systemctl is-active --quiet && systemctl stop tftpd-hpa >>$workingdir/error_logs/fog_error_${version}.log 2>&1 || true
                systemctl is-active --quiet && true || systemctl start tftpd-hpa >>$workingdir/error_logs/fog_error_${version}.log 2>&1

Probably should be:

                systemctl is-active --quiet tftpd-hpa && systemctl stop tftpd-hpa >>$workingdir/error_logs/fog_error_${version}.log 2>&1 || true
                systemctl is-active --quiet tftpd-hpa && true || systemctl start tftpd-hpa >>$workingdir/error_logs/fog_error_${version}.log 2>&1

[Sebastian Roth]

@Daniel-Miller Thanks for reporting! Obviously hasn’t been noticed in a while. I just pushed a fix to working-1.6.

Moving this to section bug reports and marking as solved.