DHCP configuration bug

[Sebastian Roth]

@Wayne-Workman Shall we have a false case for those statements like:

[[ $(validip $routeraddress) -eq 0 ]] && echo "    option routers $routeraddress;" >> "$dhcptouse" || echo "    option routers-seams-to-not-be-a-valid-ip $routeraddress;" >> "$dhcptouse"
[[ $(validip $dnsaddress) -eq 0 ]] && echo "    option domain-name-servers $dnsaddress;" >> "$dhcptouse" || echo "    option domain-name-servers-seams-to-not-be-a-valid-ip $dnsaddress;" >> "$dhcptouse"

This would cause the DHCP server to fail on start I’d say!

Beside that I wonder why you had the full isc-dhcp config string in your .fogsettings file. Cannot find anything in the scripts that might cause this. Cannot reproduce either. Added by hand?

[Wayne Workman]

@Sebastian-Roth said:

Beside that I wonder why you had the full isc-dhcp config string in your .fogsettings file. Cannot find anything in the scripts that might cause this. Cannot reproduce either. Added by hand?

Did not edit by hand. This was installed back when FOG Trunk was still in the 2xxx SVN numbers. The installer used to put the string in the .fogsettings file like that, a long time ago.

We updated that site from SVN 2xxx to the latest on Friday.

[Wayne Workman]

@Sebastian-Roth said:

[[ $(validip $routeraddress) -eq 0 ]] && echo "    option routers $routeraddress;" >> "$dhcptouse" || echo "    option routers-seams-to-not-be-a-valid-ip $routeraddress;" >> "$dhcptouse"
[[ $(validip $dnsaddress) -eq 0 ]] && echo "    option domain-name-servers $dnsaddress;" >> "$dhcptouse" || echo "    option domain-name-servers-seams-to-not-be-a-valid-ip $dnsaddress;" >> "$dhcptouse"

This would cause the DHCP server to fail on start I’d say!

I am in support of Sebastian’s idea, for the record.

[Wayne Workman]

@Sebastian-Roth https://github.com/FOGProject/fogproject/pull/91

Created a pull request for these changes.

[Tom Elliott]

I don’t know that either of those two items are “crucial”. What about the cases where people don’t want to specify a router’s option (e.g. proxyDHCP setup – I’m pretty sure ISC-DHCP is also capable in a proxy dhcp configuration mode) or a DNS address?

The way this was handled in the past, neither of those existed to begin with if the admin who’s doing the install didn’t want them. It changed the element from:

routeraddress="         option routers      10.13.15.254;";
dnsaddress="    option domain-name-servers      10.51.1.7; ";

To:

routeraddress="         #option routers      x.x.x.x;";
dnsaddress="    #option domain-name-servers      x.x.x.x; ";

So the lines where “there” but they were commented and unused.

I am fixing the updater portion to remove all of the match and replacing it with the valid IP in hopes to correct for the .fogsettings file. I’m also going to fix it in an attempt to read the IP out of the line to test it more appropriately.

[Tom Elliott]

Potential fix pushed.

[Tom Elliott]

Any word on this?

[Wayne Workman]

@Tom-Elliott The guy is in another country, he’s probably enjoying his Friday night right now. I’m sure we’ll hear from him on Monday.

[Tom Elliott]

@Wayne-Workman This was completely your thread lol.

[Wayne Workman]

@Tom-Elliott oh damn.