• Recent
  • Unsolved
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login
  • Recent
  • Unsolved
  • Tags
  • Popular
  • Users
  • Groups
  • Search
  • Register
  • Login

Imaging from empty image directory destroys target OS

Scheduled Pinned Locked Moved Solved
Bug Reports
3
7
2.0k
Loading More Posts
  • Oldest to Newest
  • Newest to Oldest
  • Most Votes
Reply
  • Reply as topic
Log in to reply
This topic has been deleted. Only users with topic management privileges can see it.
  • I
    imcdona
    last edited by Jul 7, 2014, 6:33 PM

    [B]Fog doesn’t check to ensure an image exists in source directory before wiping target computer.[/B] So long as the directory for the image is present, Fog assumes an image is present and proceeds to wipe any computers tasked to install said image before finally failing because it can’t find the image.

    A check needs to be done to ensure an image exists in said directory prior to starting the imaging process. The mere presence of a directory isn’t enough.

    Fortunately, I found this out while testing so it didn’t cause any damage.

    PS: Is this the correct place to submit bug reports or is there a bug tracker somewhere?

    Thanks

    1 Reply Last reply Reply Quote 0
    • J
      Junkhacker Developer
      last edited by Jul 7, 2014, 7:00 PM

      fog only creates a directory upon the successful creation of an image to match it. if fog is working correctly, the only way a directory exists without a proper image is if someone is manually changing things on the server.
      if fog is creating directories without first successfully creating images, then that is a bug that we would like reported. if you are wanting fog to check on changes made by users manually changing things around on the server, that’s a feature request.

      signature:
      Junkhacker
      We are here to help you. If you are unresponsive to our questions, don't expect us to be responsive to yours.

      1 Reply Last reply Reply Quote 0
      • T
        Tom Elliott
        last edited by Jul 7, 2014, 7:06 PM

        To further add to this, fog used to do the same things you’re saying without even caring if the directory was present. This little change is already a feature added. Fog is not creating directories of zero files so my guess is somebody created the directory first.

        Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

        Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

        Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

        1 Reply Last reply Reply Quote 0
        • I
          imcdona
          last edited by Jul 7, 2014, 11:27 PM

          You’re both correct. Fog isn’t creating empty directories. I created the empty directory by hand while I was troubleshooting an issue. This was an error on my part plain and simple. However, it’s not uncommon for admins to move things around outside of the Fog admin interface.

          I suggest adding a feature to check for the existence of the image prior to imaging.

          1 Reply Last reply Reply Quote 0
          • T
            Tom Elliott
            last edited by Jul 8, 2014, 1:24 PM

            The only problem I see with “checking” for the files is we don’t know what files are supposed to be present in the first place. In the case of Windows Resizable we expect at the least sys.img.000, but in the case of multipart images, there is no specific thing.

            Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

            Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

            Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

            1 Reply Last reply Reply Quote 0
            • I
              imcdona
              last edited by Jul 8, 2014, 4:44 PM

              I’m not sure what’s going on behind the scenes so take this with a grain of salt. What do you expect to see after the HD has been formatted? (I don’t think you’re formatting but whatever it is that nukes the OS). The script try’s to copy “something” and ultimately can’t find it. A check could be done prior to the formatting stage to make sure that something exists.

              1 Reply Last reply Reply Quote 0
              • T
                Tom Elliott
                last edited by Jul 8, 2014, 4:54 PM

                I understand what you’re saying. What I’m telling you is, while this check could be done to verify files for Windows Resizable images, all the others are copied in a format of d{disknum}p{partitionnumber}.img

                I can add a check for the sys.img.000 file, but there’s no common standard that states every disk is always going to be d1p1,d1p2.

                Also, how far do we take this? We’re not storing the file names anywhere right now. So if somebody comes in after we’ve created the image and deletes, randomly, some files from the directory, you would be in exactly the same state.

                Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                1 Reply Last reply Reply Quote 0
                • 1 / 1
                1 / 1
                • First post
                  3/7
                  Last post

                237

                Online

                12.0k

                Users

                17.3k

                Topics

                155.2k

                Posts
                Copyright © 2012-2024 FOG Project