Legacy Client has stopped working 1.3.3

[tmldale]

Server

• FOG Version: 1.3.3
• OS: CentOS 6

Client

• Service Version: 11.8 & 0.32
• OS: Windows

Description

I have upgraded from 1.2 to 1.3.3 the new client is working fine and has renamed computers and joined the domain fine.
I have disabled the display manager due to the following apache error which caused the new client not to work

PHP Fatal error:  Call to a member function getDispVals() on null in /var/www/html/fog/lib/client/displaymanager.class.php on line 32

Working New Client

 18/01/2017 16:16 Bus {
  "self": true,
  "channel": "Status",
  "data": "{\r\n  \"action\": \"unload\"\r\n}"
}
 18/01/2017 16:16 Bus Emmiting message on channel: Status
 18/01/2017 16:16 Main Overriding exception handling
 18/01/2017 16:16 Main Bootstrapping Zazzles
 18/01/2017 16:16 Controller Initialize
 18/01/2017 16:16 Zazzles Creating main thread
 18/01/2017 16:16 Zazzles Service construction complete
 18/01/2017 16:16 Controller Start

 18/01/2017 16:16 Service Starting service
 18/01/2017 16:16 Power Creating shutdown request
 18/01/2017 16:16 Power Parameters: /r /c "Host joined to Active Directory, restart required" /t 0
 18/01/2017 16:16 Bus {
  "self": true,
  "channel": "Power",
  "data": "{\r\n  \"action\": \"shuttingdown\"\r\n}"
}
 18/01/2017 16:16 Power ERROR: Could not create shutdown command from request
 18/01/2017 16:16 Power ERROR: Object reference not set to an instance of an object.
 18/01/2017 16:16 Bus Became bus server
 18/01/2017 16:16 Bus {
  "self": true,
  "channel": "Status",
  "data": "{\r\n  \"action\": \"load\"\r\n}"
}
 18/01/2017 16:16 Bus Emmiting message on channel: Status
 18/01/2017 16:16 Service Invoking early JIT compilation on needed binaries

------------------------------------------------------------------------------
--------------------------------Authentication--------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Version: 0.11.8
 18/01/2017 16:16 Client-Info OS:      Windows
 18/01/2017 16:16 Middleware::Authentication Waiting for authentication timeout to pass
 18/01/2017 16:16 Middleware::Communication Download: http://fogserver/fog/management/other/ssl/srvpublic.crt
 18/01/2017 16:16 Data::RSA FOG Server CA cert found
 18/01/2017 16:16 Middleware::Authentication Cert OK
 18/01/2017 16:16 Middleware::Communication POST URL: http://fogserver/fog/management/index.php?sub=requestClientInfo&authorize&newService
 18/01/2017 16:16 Middleware::Response Success
 18/01/2017 16:16 Middleware::Authentication Authenticated


 18/01/2017 16:16 Bus Registering ParseBus in channel Power
 18/01/2017 16:16 Middleware::Communication URL: http://fogserver/fog/management/index.php?sub=requestClientInfo&configure&newService&json
 18/01/2017 16:16 Middleware::Response Success
 18/01/2017 16:16 Middleware::Communication URL: http://fogserver/fog/management/index.php?sub=requestClientInfo&mac=00:00:00:00:00:00:00:E0|00:00:00:00:00:00:00:E0|00:00:00:00:00:00:00:E0&newService&json
 18/01/2017 16:16 Middleware::Response Success
 18/01/2017 16:16 Middleware::Communication URL: http://fogserver/fog/service/getversion.php?clientver&newService&json
 18/01/2017 16:16 Middleware::Communication URL: http://fogserver/fog/service/getversion.php?newService&json

 18/01/2017 16:16 Service Creating user agent cache
 18/01/2017 16:16 Middleware::Response Module is disabled globally on the FOG server
 18/01/2017 16:16 Middleware::Response Module is disabled globally on the FOG server
 18/01/2017 16:16 Middleware::Response Module is disabled globally on the FOG server
 18/01/2017 16:16 Service Initializing modules

------------------------------------------------------------------------------
---------------------------------ClientUpdater--------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Success
------------------------------------------------------------------------------


------------------------------------------------------------------------------
----------------------------------TaskReboot----------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Success
------------------------------------------------------------------------------


------------------------------------------------------------------------------
--------------------------------HostnameChanger-------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Success
 18/01/2017 16:16 HostnameChanger Checking Hostname
 18/01/2017 16:16 HostnameChanger Hostname is correct
 18/01/2017 16:16 HostnameChanger Attempting to join domain
 18/01/2017 16:16 HostnameChanger The machine is already joined to the domain, code =  2691
------------------------------------------------------------------------------


------------------------------------------------------------------------------
---------------------------------SnapinClient---------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response No snapins
------------------------------------------------------------------------------


------------------------------------------------------------------------------
--------------------------------PrinterManager--------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Module is disabled globally on the FOG server
 18/01/2017 16:16 PrinterManager Getting installed printers
------------------------------------------------------------------------------


------------------------------------------------------------------------------
--------------------------------PowerManagement-------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Success
 18/01/2017 16:16 PowerManagement Calculating tasks to unschedule
 18/01/2017 16:16 PowerManagement Calculating tasks to schedule
------------------------------------------------------------------------------


------------------------------------------------------------------------------
----------------------------------UserTracker---------------------------------
------------------------------------------------------------------------------
 18/01/2017 16:16 Client-Info Client Version: 0.11.8
 18/01/2017 16:16 Client-Info Client OS:      Windows
 18/01/2017 16:16 Client-Info Server Version: 1.3.3
 18/01/2017 16:16 Middleware::Response Success
------------------------------------------------------------------------------

 18/01/2017 16:16 Service Sleeping for 98 seconds

In the old client I just get this. Client is in the same group as the new client

18/01/2017 17:20 Starting all sub processes
 18/01/2017 17:20 13 modules loaded
 18/01/2017 17:20  * Starting FOG.AutoLogOut
 18/01/2017 17:20  * Starting FOG.SnapinClient
 18/01/2017 17:20 FOG::AutoLogOut Starting process...
 18/01/2017 17:20  * Starting FOG.DirCleaner
 18/01/2017 17:20 FOG::DirCleaner Sleeping for 36 seconds.
 18/01/2017 17:20  * Starting FOG.DisplayManager
 18/01/2017 17:20 FOG::ClientUpdater Starting client update process...
 18/01/2017 17:20 FOG::ClientUpdater Sleeping for 156 seconds.
 18/01/2017 17:20  * Starting FOG.GreenFog
 18/01/2017 17:20 FOG::DisplayManager Starting display manager process...
 18/01/2017 17:20  * Starting FOG.GUIWatcher
 18/01/2017 17:20 FOG::GUIWatcher Starting GUI Watcher...
 18/01/2017 17:20  * Starting FOG.HostNameChanger
 18/01/2017 17:20 FOG::GreenFog Sleeping for 37 seconds.
 18/01/2017 17:20  * Starting FOG.HostRegister
 18/01/2017 17:20 FOG::HostnameChanger Starting hostname change process...
 18/01/2017 17:20 FOG::HostnameChanger Yielding to other subservices for 3 seconds.
 18/01/2017 17:20  * Starting FOG.MODDebug
 18/01/2017 17:20 FOG::HostRegister Starting host registration process...
 18/01/2017 17:20  * Starting FOG.SnapinClient
 18/01/2017 17:20 FOG::MODDebug Start Called
 18/01/2017 17:20 FOG::MODDebug Sleeping for 100 Seconds
 18/01/2017 17:20  * Starting FOG.TaskReboot
 18/01/2017 17:20 FOG::SnapinClient Starting snapin client process...
 18/01/2017 17:20  * Starting FOG.UserCleanup
 18/01/2017 17:20 FOG::TaskReboot Taskreboot in lazy mode.
 18/01/2017 17:20 FOG::TaskReboot Starting Task Reboot...
 18/01/2017 17:20  * Starting FOG.UserTracker
 18/01/2017 17:20 FOG::UserCleanup Sleeping for 15 seconds.
 18/01/2017 17:20 FOG::UserTracker Starting user tracking process...
 18/01/2017 17:20 FOG::HostRegister Exiting because only 1 mac address was found.
 18/01/2017 17:20 FOG::SnapinClient Sleeping for 419 seconds.
 18/01/2017 17:20 FOG::DisplayManager Attempting to connect to fog server...
 18/01/2017 17:20 FOG::UserTracker Attempting to connect to fog server...
 18/01/2017 17:20 FOG::DisplayManager Module is disabled globally on the FOG Server.
 18/01/2017 17:20 FOG::AutoLogOut Module is disabled globally on the FOG Server.
 18/01/2017 17:20 FOG::UserTracker Module is disabled globally on the FOG Server, exiting.
 18/01/2017 17:20 FOG::HostnameChanger Attempting to connect to fog server...
 18/01/2017 17:20 FOG::HostnameChanger Module is disabled globally on the FOG Server, exiting.
 18/01/2017 17:21 FOG::UserCleanup Starting user cleanup process...
 18/01/2017 17:21 FOG::UserCleanup Attempting to connect to fog server...
 18/01/2017 17:21 FOG::UserCleanup Module is disabled globally on the FOG Server, exiting.
 18/01/2017 17:21 FOG::DirCleaner Starting directory cleaning process...
 18/01/2017 17:21 FOG::DirCleaner Attempting to connect to fog server...
 18/01/2017 17:21 FOG::DirCleaner Module is disabled globally on the FOG Server.
 18/01/2017 17:21 FOG::GreenFog Starting green fog...
 18/01/2017 17:21 FOG::GreenFog Attempting to connect to fog server...
 18/01/2017 17:21 FOG::GreenFog Module is disabled globally on the FOG Server, exiting.
 18/01/2017 17:22 FOG::MODDebug Reading config settings...
 18/01/2017 17:22 FOG::MODDebug Reading of config settings passed.
 18/01/2017 17:22 FOG::MODDebug Starting Core processing...
 18/01/2017 17:22 FOG::MODDebug Operating System ID: 6
 18/01/2017 17:22 FOG::MODDebug Operating System Minor: 1
 18/01/2017 17:22 FOG::MODDebug MAC ID 0 XXXXXXXXXXXXXX
 18/01/2017 17:22 FOG::MODDebug MAC POST String: XXXXXXXXXXXXX
 18/01/2017 17:22 FOG::MODDebug A user is currently logged in
 18/01/2017 17:22 FOG::MODDebug Username: IMAGE-JRE926NCM\Administrator
 18/01/2017 17:22 FOG::MODDebug Hostname: IMAGE-JRE926NCM
 18/01/2017 17:22 FOG::MODDebug Attempting to open connect to: http://fogserver/fog/service/debug.php
 18/01/2017 17:22 FOG::MODDebug Server responded with: Hello FOG Client
 18/01/2017 17:22 FOG::MODDebug Module has finished work and will now exit.
 18/01/2017 17:23 FOG::ClientUpdater Attempting to connect to fog server...
 18/01/2017 17:23 FOG::ClientUpdater Module is disabled globally on the FOG Server, exiting.
 18/01/2017 17:27 FOG::SnapinClient Attempting to connect to fog server...
 18/01/2017 17:27 FOG::SnapinClient Module is disabled globally on the FOG Server, exiting.```

[Tom Elliott]

I’ve moved this to bugs as it is clearly such a thing.

I’ve confirmed the issue and have a fix already staged for this. I’m just running through a few tests to try to ensure all is working more or less properly.

I want to add, while the legacy client is still supported, I’m not overly concerned with things that Windows Vista and up don’t work well with even if all legacy items are working properly from the server side. These things I’m not overly concerned with (as they won’t work on Vista and forward) are:

1. User Cleanup.
2. Dir Cleaner.

I’ve no printers I can test with currently so this will not be a part of my testing.

Currently tested and back to functional from the legacy client:

1. Task Reboot.
2. Domain Join.
3. MAC Register.

I will update this post as more of the tests and/or fixes to make sure they work are completed/verified.

[Tom Elliott]

So, after a bit of digging, I found out a few things had logic flaws. In particular, what you’re seeing for the Globally Disabled was due to corrective code from 1.3.1 (I think?). This corrective code forgot to take into account legacy clients initially. This has been addressed now and I’ve tested it as described earlier.

More detail on the global disabled for legacy client can be seen here:
https://github.com/FOGProject/fogproject/commit/3fe54ced5c8beede71434ffc5227b2c1ee97e190
There were a couple other bugs fixed in the above link but it also addresses the issue described here.

For the second part, I added an argument to our getClass method to simply return properties of another class. However, the arguments I was passing was intended to go with the calling/instantiating of the working class item. Only user tracking appears to have required this adjustment, but to help prevent further issues I am now implicitly calling the object with the new keyword. The getClass method is intended to be used so we can immediately chain other caller functions rather than storing the object into a variable.
You can see details here:
https://github.com/FOGProject/fogproject/commit/06636dcc7e0778e0448b0de0fc2153bc75b9717a

[tmldale]

@Tom-Elliott You are amazing keep up the great work!!!

Been using fog since the early days (0.20) we have around 600 clients that will be using the old client until new images are made with the new client in mind.
Is there any set date/version the old client will be stopped?

Will you been releasing 1.3.4 in the next few days or should I just install the working-1.3.4 branch now?

Cheers

[Tom Elliott]

@tmldale The legacy client won’t be killed out of the 1.3.x series of FOG so really I don’t think it will just be stopped (in this particular sense). I don’t think we plan to have separate clients for our next major version of fog though due to how we’re contemplating handling things. Hopefully this answers that question.

[tmldale]

@Tom-Elliott Have upgraded to the 1.3.4 after seeing your post here and can confirm the getDispVals() error is gone and Legacy Client is now working great

Cheers

[Tom Elliott]

Thanks for reporting back.