MBP 13" 2017 Touchbar - OSX Mojave - Fog can't find a disk

[Sebastian Roth]

@rhulet Oh well, just started the compilation and when I got back from the bathroom it was done already: https://fogproject.org/kernels/Kernel.TomElliott.5.1.16_mac-nvme-fix.64

Edit: echo 106b 2005 > /sys/bus/pci/drivers/nvme/new_id should not be needed with this one as far as I understand the patch.

No guarantee this will run with our inits… untested kernel!!

[george1421]

I would download the new 5.x kernel and place it in the /var/www/html/fog/service/ipxe directory as bzImage5116 Then go into the host definition for this mac and set the kernel parameter to bzImage5116…

Crud I forgot you are using a usb stick. Copy that to the usb stick as bzImage in the /boot directory (you might want to save the original kernel). Then boot into debug mode again and do a lsblk command to see if the nvme disk is seen.

[Sebastian Roth]

@rhulet Any news on this?

[Sebastian Roth]

@rhulet We’ve pushed this quite far and I’d hope you read this and test the kernel I compiled for you!

[rhulet]

So sorry Sebastian! I was out of the office and got put on another project. I will test this today! Thank you!

[rhulet]

When I boot into debug, I get an unable to access /index.php for connection testing

[Sebastian Roth]

@rhulet Sounds like a network driver issue. But network did work earlier, right? Can you please take a picture of that error and post here?

[rhulet]

Nevermind I’m dumb. I forgot the butterfly keyboard doesn’t work with the kernal. I plugged in a usb and hit enter and its working. I can see the nvme drive. Lets see if I can drop an image!

[rhulet]

Update. Good news, I was able successfully capture and deploy an image from one 2017 mbp to another. Thanks!

[george1421]

OK so where did we end up here? Did applying the T2 kernel github patch resolve the issue or just adding subsystem ID to the nvme driver kernel parameter fix the issue?

[rhulet]

@george1421 Using the kernal provided by @Sebastian-Roth at https://fogproject.org/kernels/Kernel.TomElliott.5.1.16_mac-nvme-fix.64 was all I needed. Worked like a charm.

[Sebastian Roth]

It’s been almost a months and I am not 100% sure which patch I added. I think it was the one mentioned here: https://github.com/Dunedan/mbp-2016-linux/issues/71#issuecomment-510715810 (patch)

Will check later on today on the build server. Should still be there.

[Sebastian Roth]

@george1421 Yes indeed it was this patch I used. I don’t really fancy having it in our official build.

@rhulet Would you mind being the housekeeper for this special Mac patch? We can show you how to build and add the patch. It’s not very hard if you know how to use the Linux terminal.

[Quazz]

As an aside, Linux kernel 5.3 has added native support for keyboard in these models.

[rhulet]

@Sebastian-Roth yeah I’d be happy to take it, just show me what to do.

[Sebastian Roth]

@rhulet I’ll show you how to bake your own kernel. Though George suggested adding the patch to our official kernel. I am still not sure if it’s wise to do or not.

Use any kind of Linux machine you have at hand:

git clone https://github.com/FOGProject/fos
cd fos
grep KERNEL_VERSION Jenkinsfile
export KERNEL_VERSION=4.19.64
./build.sh -kn -a x64

See if that runs trough withou an issue.

[rhulet]

Build successful. Where did it dump it at though?

[Sebastian Roth]

@rhulet Ok, nice! You will find the new kernel binary in fos/kernelsourcex64/arch/x86/boot/bzImage. Copy that to your FOG server in /var/www/html/fog/service/ipxe/ but I suggest you rename the original bzImage in that directory instead of overwriting it. Just so you have a surely working backup copy of the kernel.

Now, applying the patch I notice that I gave you instructions for building our current kernel version. But for this stuff you need to use a newer one. Sorry for that. Move that 4.19.64 code out of the way, you might want to use it some other time:

cd fos
mv kernelsourcex64 kernelsourcex64_4.19.64

Now add the patch and build the newer kernel:

export KERNEL_VERSION=5.1.16
./build.sh -kn -a x64
wget https://ozlabs.org/~benh/nvme-mac-5.1.16.diff
cd kernelsourcex64
patch -p1 < ../nvme-mac-5.1.16.diff
make

This will get you the same kernel version I built for you some days ago. But there also seems to be a patch for kernel 5.2. If you want to give that a try instead:

export KERNEL_VERSION=5.2
./build.sh -kn -a x64
wget https://ozlabs.org/~benh/nvme-mac.diff
cd kernelsourcex64
patch -p1 < ../nvme-mac.diff
make

This last one is untested.