The future of partclone and therefore FOG as it is

Quazz

Okay, so I can’t believe I never noticed this, but -aX0 is an invalid parameter, it should be -a0

Source: https://github.com/Thomas-Tsai/partclone/blob/master/src/partclone.c

		"    -aX  --checksum-mode=X  Checksum formula to use to add error detection\n"
		"                            where X:\n"
		"                            0: No checksum (no slowdown, smallest image)\n"
		"                            1: CRC32 (Fast to compute, basic detection)\n"

Hopefully the source of the funky problem I was having, rebuilding now.

Quazz

The error I was getting seems to be originating from zstdmt, it doesn’t have an rsyncable option in the included version. Would have thought that would be bundled by now, grrr.

george1421

@Quazz I think in my dev environment I change the BR package to download zstd 1.4.0. My build environment server had bad ssd, so I’m going to rebuild it. I can’t get to the files at the moment to confirm through.

edit: Yes zstd 1.4.0
zstd.mk: ZSTD_VERSION = v1.4.0

Quazz

@george1421 I decided to go for 1.4.2 since it includes a couple of performance improvements and bug fixes.

Took a while longer because I forgot to include the hash file.

It’s finally compiling successfully, time for some more tests.

Quazz

Currently it fails to capture msftres partitions, throwing exit code 139 (presumably zstd’s error code). msftres is captured with partclone.imager

It’s difficult to see what’s going on because the screen breaks up, but it seems to not recognize any size on this type of partition on partclone 3.12 which is a regression compared to 2.89

edit: Adding a strategic debugPause tells me there is a segmentation fault on line 2041 in funcs.sh

Even stranger is that it is talking about line 2053, yet for some reason mentions line 2041???

Though not sure why this occurs…

edit2: Seems to be down to the fact that it writes to /tmp/pigz1

Direct writing to /images works fine

edit3: Welp, it seems to come and go as it pleases, not sure what the actual cause is!

edit4: My suspicion lies on B128 option being the culprit (initial test is promising), recompiling, will test tomorrow.

Quazz

Removing the -B128 option seems to allow it to capture, finally!

64 bit init.xz Buildroot 2019.02.4 + ZSTD 1.4.2 + Partclone 0.3.12 (with APFS support)

32 bit init.xz Buildroot 2019.02.4 + ZSTD 1.4.2 + Partclone 0.3.12 (with APFS support)

Give it a whirl if you’re interested.

Current status:

Specifying the -B128 option gives issues in certain scenarios (special partitions/raw/very small ones???), so we can’t reliably use that.
In order to use --rsyncable, zstd had to be updated to a minimum of 1.3.8 (chosen the latest version of 1.4.2 to include performance improvements and bug fixes)
Minor Buildroot update means config doesn’t have to be updated, it’s just bugfixes
Added APFS support so that we can offer some better support for newer Macs (if they decide to PXE boot that is) (potentially gptfdisk package should be updated to 1.0.4 (adds typecodes for APFS and others), haven’t tested anything in this direction!)

Quazz

I’m also wondering if we should look into updating other packages that FOG either overrides or provides manually. (eg testdisk is on 6.14 as opposed to 7.1 and even pigz is at 2.3.4 instead of 2.4 (although pigz seems to have introduced potentially backwards incompatible changes))

george1421

@Quazz Great news that you got it to compile. Also APFS support was a current topic wondering if it was going to be supported. So good idea to add that support. To make use of that will the web gui need to be updated to for a different operating system type?

I’ll download the inits a bit later today to try them in my environment. I’m still running FOG 1.5.5 FWIW.

As for updating other packages… (understand this is just my opinion) You installed buildroot 2019.02.1 which is the same as what the developers are using. Every time you deviate from the standard buildroot package you run the risk of introducing unexpected bugs. I would say unless there is a compelling reason (fog needs a feature of the update package or to fix a bug fog is hitting) don’t upgrade packages at random. Let the buildroot devs do that leg work. I also saw that pigz had an updated version and I think I saw the incompatibility statements so I decided to not update that in my build. That was simply because pigz supported the resyncable flag that we were looking to implement. So I would recommend that unless we are trying to solve a problem, I would say hold off on updating any packages beyond the buildroot stream. I would rather want stable over new unneeded features.

Great job on getting the inits compiled and working!! I’ll let you know how it works on my stuff.

Quazz

@george1421 I agree for vital packages that waiting on Buildroot where possible is preferable, but something like Testdisk (which doesn’t come from Buildroot) could surely use a bump since that doesn’t break anything

You installed buildroot 2019.02.1

2019.02.4 actually, which doesn’t fundamentally changes any packages, just a bunch of bugfixes!

george1421

@Quazz said in The future of partclone and therefore FOG as it is:

which doesn’t come from Buildroot

Ah so its a fog supplied package. Well then that changes the equation a bit. If its fog project supplied and its tested then there is probably no reason why we should not update. My concern is deviating from the norm that buildroot devs create.

george1421

@Quazz You might want to include the nvme package in your build too. Hopefully that will help us solve the issue with the nvme disk swapping. Its not important for this new init testing, but it may be of some use in the future.

Symbol: BR2_PACKAGE_NVME [=n] x x
x x Type : bool x x
x x Prompt: nvme x x
x x Location: x x
x x -> Target packages x x
x x -> Hardware handling x x

Quazz

Had a kernel error of rootfs can’t mount blablabla on a device today, normal init works fine. Ramdisk size is at 275000 currently.

Unsure why this happened.

edit: Might just be a machine issue as it seems to be acting up in other ways too (namely freezing)

Quazz

Would be great if we could come to a satisfactory answer on this matter. Unfortunately I reached the limit on what I can test on my end (all good), but obviously we want to be sure it works at least as well as the older version for everyone.

Sebastian Roth

@Quazz Sorry for staying away from this so far. Guess there is not much I can add as I can only test on VirtualBox. I’ll still do that later on an get back to you. Is it still the download links you posted 20 days ago?

Quazz

@Sebastian-Roth Those should still work yes. Also created a PR on github, so through that way people could check it out too I suppose.

We only really have consumer grade hardware here, rarely anything special, so I know it will work in most scenarios, just need to know if it also works in those other scenarios!

Sebastian Roth

@george1421 @Junkhacker We had to sort through a couple of things in the pull request and I was just able to merge it all in. It’s build and everyone can test the binaries build from current master here: https://dev.fogproject.org/blue/organizations/jenkins/fos/detail/master/95/artifacts

I will try to do my testing on the weekend. Would be great if you find the time to do tests on your systems in the next days as well.

Junkhacker

@Sebastian-Roth FYI zstd 1.4.3 is out. it’s a just a bug-fix upgrade, and a bug that’s probably not relevant to our use case, but we should probably upgrade anyway.

Quazz

@Junkhacker Sebastian and I discussed ZSTD a bit and the coin kind of fell on the “let’s keep ZSTD at this version until Buildroot catches up” to keep things a bit simpler and requiring less maintenance from the dev team.

There are other tools in the toolchain that could theoretically also be upgraded, but at the point you’re putting so much maintenance on the board for any future release that you have to question why you’re using a bundled package like Buildroot anymore.

george1421

@Quazz said in The future of partclone and therefore FOG as it is:

“let’s keep ZSTD at this version until Buildroot catches up

I also agree with this quote. The only exception would be if a certain package had a documented error that would be fixed by an update or The FOG Project needed a feature in a package that is not available in the current buildroot release.

The developers have enough on their plates keeping the project moving forward to have to think about every package and if we are running the latest version of each package. Its roughly equivalent to deciding which OS to install, bleeding edge fedora or a bit older (mature) but more stable OS like CentOS.

Junkhacker

@george1421 i only brought it up because we’re updating ztsd for this build anyway, so i figured “why not have the latest one?”

The future of partclone and therefore FOG as it is

212

12.0k

17.3k

155.2k