advanced menu bug

[Junkhacker]

after upgrading from 1.4.4 to 1.5.6 the advanced menu no longer automatically had #!ipxe at the top, resulting in the computer just sitting at a blinking cursor

[Junkhacker]

@Junkhacker found that someone else had what looks like the same bug https://forums.fogproject.org/post/123064 mine didn’t beep, but i’m not certain i have a speaker for it to beep with.

[Sebastian Roth]

@Junkhacker Might be related? https://forums.fogproject.org/topic/12911/chainloading-failed-advanced-menu

[Junkhacker]

@Sebastian-Roth maybe so. i was able to make my advanced menu work properly by adding #!ipxe to the top of my advanced menu text box. that wasn’t needed before, since it was automatically put in in previous versions.

[Junkhacker]

@Junkhacker i’ve finished reading through that thread and i still don’t understand why the code was changed to require the menu to have #!ipxe entered manually

[Sebastian Roth]

@Junkhacker I removed that in the process of trying to help @Scott-B make the advanced menu work for him. I have to say that I have not used that part of FOG much and therefore might have gone down the wrong path when I removed the leading #!ipxe from the code.

Back then it sounded like @Scott-B had it all working and it stopped for some unknown reason. But seems like I got that wrong. I am more than happy to revert this change as it seems like people are used to have it the other way and it breaks all their advanced menus.

Shall I just revert this commit? https://github.com/FOGProject/fogproject/commit/123cde2a2df78727b1b813e6f363c8f919a9a1c2#diff-f21fb2470403477fe0c412911d1227f1

[Junkhacker]

@Sebastian-Roth that seems like the right thing to do. those who do use this feature often rely on it heavily, so it’s best to not break existing configurations on an update.

[Sebastian Roth]

@Junkhacker Done https://github.com/FOGProject/fogproject/commit/f943e3a8690110fd7b469b40e38f3d26512ddc18