Migrate custom client banner image in filesystem when updating

[x23piracy]

Hi,

is it possible to add a client banner image migration code line to keep the pure file in filesystem if it’s not the default one? I would not except that someone names it exactly like the default but if we should keep it always but could be contrac productive if the default one should be updated anytime, a possible solution would be a file sizecheck or hash.

Regards X23

[Wayne Workman]

What do you mean by client banner? Where is this file located? What’s it for?

[x23piracy]

@wayne-workman oh to unprecise…

look here:

talking about the fog clients custom logo:

This gets lost on updating, not the settings, but the custom file in filesystem path, you always have to copy it from the backup path back to its place. It would be really convenient if it could be kept.

../service/ipxe/filename.png

Check if current banner sha is same as default one, then skip keeping it, if different keep it.

Regards X23

[Wayne Workman]

@x23piracy I can fix that - give me a bit.

[x23piracy]

@wayne-workman take your time, i thougth about that often but never made the request.
I think you are going to extend the fog install script for it?

[Wayne Workman]

@x23piracy said in Migrate custom client banner image in filesystem when updating:

I think you are going to extend the fog install script for it?

Yep, probably by one line.

[Wayne Workman]

@x23piracy I just looked into this - I cannot replicate. I’ve tried both with master branch and working branch. Also, it would appear that the image is placed into /var/www/fog/management/other/

[Sebastian Roth]

@x23piracy Have you looked into this again?

[x23piracy]

Hi,

i am still not sure if the banner will be kept when updating.
I was helping some guy remotely and we updated fog after that he was missing his banner.

Then i digged in the backup and copied it back to it’s place, that was the reason i’ve opened this here.

Afai remember in the past (older releases) we also had to copy a custom pxe background again and again if fog has been updated. So i am not sure what is kept and what not.

So what i want is to know is, do current releases keep the banner if there is a custom one?

Regards X23

[Tom Elliott]

@x23piracy If you use the “copybackold” element it will copy back all original files from the backup it generates.

[x23piracy]

@tom-elliott oh, didn’t knew that, this is a switch for the installer script?

Regards X23

[Sebastian Roth]

@x23piracy Installer switch --oldcopy and/or .fogsettings parameter copybackold=…