Email notification format has changed, missing word wrap

[x23piracy]

Hi,

between the last RC’s i don’t know exactly when this has changed:

[Quazz]

Looks like the <br> tags are missing for the bottom details.

[x23piracy]

@Quazz said in Email notification format has changed, missing word wrap:

Looks like the <br> tags are missing for the bottom details.

Should be easy for @Tom-Elliott to fix.

[Tom Elliott]

https://github.com/FOGProject/fogproject/issues/140

This same release just “tidies” up the email code. The basis behind it has not changed though.

Particularly starting here in the diff:

https://github.com/FOGProject/fogproject/commit/30415aee5a0533c0f828437f144ee11b6e3ef4a3#diff-950f32ffd810569339d2aba98781d6d2R271

You can see each of the lines have new lines and about half of yours had the same new lines already created. You can play around with it if you’d like to see if anything can help correct it, but I assure you the new lines haven’t changed nor has the operation of sending the email, so this seems really odd to me.

[x23piracy]

RC25 still missing <br>

[Quazz]

@x23piracy I assumed it used html language to create emails, but it does not, it’s plain text. I looked over the code Tom posted and I can’t see anything out of place, so not sure what to think about this.

[x23piracy]

@Quazz oh sorry haven’t checked for plain but anyway for the upper part a line break is working why not for the rest of the email?
This is not really important it’s just cosmetic.

Regards X23

[Tom Elliott]

I don’t use <br/> or <br> tags anywhere in the email.

All of them use the “new line” character \n (Including the top.)

[x23piracy]

@Tom-Elliott said in Email notification format has changed, missing word wrap:

I don’t use <br/> or <br> tags anywhere in the email.

All of them use the “new line” character \n (Including the top.)

Yeah i understood that, was learning that while trying to open email source code while there is nothing of it, that means no html

Regards X23

[x23piracy]

Strange… i changed nothing just deployed a different computer and i see:

Whoot?

[Quazz]

@x23piracy Looks this only happens with your Windows 10 1607 Office ProPlus image. Can you confirm?

edit: this could also be down to the mail client

[x23piracy]

@Quazz said in Email notification format has changed, missing word wrap:

@x23piracy Looks this only happens with your Windows 10 1607 Office ProPlus image. Can you confirm?

edit: this could also be down to the mail client

Hi, yes i just need time to deploy other images, don’t want to do this for fun being busy here with other work but i am sure i need deploy other images in the next days, i get back…