[RC19] Snapin Replication not working

[Tom Elliott]

@mp12 Mind jumping on the working-RC-20 branch and see if this is now cleared?

Basically I’m an idiot and you should slap me…

The image replicator and snapin replicator services are essentially clones of one another. As imaging replication has been around for a lot longer, it’s relatively simple to know that I more or less copied that service and made modifications to make it “snapin” capable. In one of my many refactors, I forgot to adjust some of the copied lines (only two really I can find currently) that related to actually wanting the snapin, vs, image. I had a line (and you can confirm if you’d like first) at line 203 of /var/www/fog/lib/service/snapinreplicator.class.php that probably has something like $Image->get( when it really should’ve been $Snapin->get.

I’m sorry :(.

[mp12]

@Tom-Elliott

No one is going to slap you! Thanks for the great support. I update to RC-20.

Unfortunately I am get a new error when creating a snapin.

Snapin ID 110 is not valid

/var/log/apache2/error.log shows:

[Mon Nov 07 07:57:40.073360 2016] [:error] [pid 14613] [client x.x.x.x:28288] PHP Warning:  array_map(): Argument #2 should be an array in /var/www/fog/lib/fog/storagenode.class.php on line 216, referer: http://x.x.x.x/fog/management/index.php?node=snapin

[Tom Elliott]

@mp12 There were two things going on here, which have no been republished as RC-20 to ensure all will be well.

I renamed a variable for ease, but where it set’s the snapin name was calling the “bad” variable (which was unset) leaving the snapin without a name. All other things worked right (the upload, args, etc…) but would report failed because it was setting the name to a null value which is not allowed.

The ID you see shows it actually did get created though.

The error message you posted had nothing to do with the create of the snapin, but rather the creating of the “File Exists” listing. My isAvailable method was working properly but not removing the requests from the url queue after it returned the available status. Both of these things are now fixed in RC-20 if you’d be so kind as to repull and reinstall.

[mp12]

@Tom-Elliott

Thanks Tom!
Replication works fine again. I also deleted the snapin with ID 110 manully from the db.

[mp12]

@Tom-Elliott

Server

• list itemFOG Version: 1.3.0 RC-21 (6014)
• list itemOS: Ubuntu 14.04

Client

• Service Version: 0.11.5
• OS: Win7

Description

Replication stopped working
The Snapins which should get replicated won’t appear in the fogsnapinrep.log file.

[Tom Elliott]

@mp12 Should be re-fixed in the latest.

Had a cleanup bit for 21 and missed the count grading system. This should be corrected for now in the working-RC-22 branch (which if I get a test I will push up probably this evening.)

[Tom Elliott]

RC-22 officially released.

I’m seeing stuff replicating once again.

Thanks for informing.

[mp12]

@Tom-Elliott

Nodes are not replicating yet. Restarted the FOGSnapinReplication but nothing new.
fogsnapinrep.log shows only existing snapins but not new created ones.
apache2/error.log shows nothing new.

[Tom Elliott]

@mp12 Is the snapins set to replicate?

Thanks for reminding me on this. I realized recently (but had bigger bugs to tackle first) that the replicate checkbox is not set on fresh creations.

[mp12]

@Tom-Elliott

Found the error. After creating a new snapin and enabling it on creation, I rechecked the snapin and found that the checkbox Snapin Enabled was empty. Set a check mark, restarted replication and it uploaded the snapisn to the nodes.

[Tom Elliott]

I found the isEnabled issue. This was only present on new snapins. It’s fixed for RC-23 (while annoying it’s not as important as the functionality of the client which I’m more focused on anyway, among the other issues RC-22 was released to help correct).