Updating group module configuration updates screen resolution and auto logout too



  • FOG 1.5.0
    Firefox 59.0.2

    Clicking on the button “Group Management - Update module configurations - Update” updates screen resolution and auto logout too (overwrites with the default values).



  • FOG 1.5.2 (working-branch)

    Tested - works as expected. Thanks.



  • @tom-elliott
    FOG 1.5.0

    Tested it, same behaviour with the other buttons in the group menu:

    hitting “Update display resolution” changes the values under module configuration and auto-logout time too,
    hitting “Update auto-logout time” changes the values under module configuration and display resolution too.

    I will test the working branch as soon as possible.


  • Senior Developer

    So I looked over the code as I was unsure what you were trying to say, and still am to some level.

    That said, looking at the code I did notice these fields were all wrapped in a single form. I’ve since separated them into individual forms. I performed the same for hosts.

    Please checkout the working branch and let me know if this fairs better for what you’re looking to do.


  • Senior Developer

    @trialanderror I need implicit information. Yes from The group page the autologout and display settings will reset to defaults already defined. What I need to know is if you are changing the autologout or screen settings, saving the element, are the hosts in the group updated with the information?



  • @tom-elliott
    Yes.

    Tested it again. Seconds before.


  • Senior Developer

    @trialanderror what I’m saying is the fields aren’t representing the data of all hosts. It’s representing the value set globally. When you change module settings you host alo and host screen stuff is being set to the default values?



  • @tom-elliott

    What do you mean, overwrites the default values?

    overwrites WITH the default values

    They should be in their own form elements though, so if you update the modules, it doesn’t update the display/autologout.

    It DOES. - I tested several times. This is definitely no feature …


  • Senior Developer

    What do you mean, overwrites the default values? This is intended for these two fields. Groups are not a perfect thing, and having to call each host, test each host’s value, and then if they all match display, otherwise don’t, takes a LOT of resources. So for groups, (the simple text stuff is much easier than dealing with different tables – as is the case for autologout and display settings) The idea is to use the predisposed defaults. They should be in their own form elements though, so if you update the modules, it doesn’t update the display/autologout.

    I guess what i’m trying to say is this isn’t a bug, this is intended behavior for groups.


 

547
Online

5.4k
Users

12.6k
Topics

118.7k
Posts