Latest FOG 0.33b

[jbsclm]

Hi Tom, hope you are feeling OK. just checking out your 1197 version of FOGConfigurationPage.Class.php, unfortunately it still has problems
It doesn’t populate the text area, due to “print” missing on line 423.

Line 423 needs to be as below, I’ve also increased the height of the text box from 5 to 25, to make it more usable for those of us who have several other boot menu entries.
<textarea rows=“25” cols=“64” name=“adv”><?php print $this->FOGCore->getSetting( “FOG_PXE_ADVANCED” ) ?></textarea></div></td>

also it doesn’t save the setting to “FOG_PXE_ADVANCED” due to a typo on line 479
if ($advandedOpts)
should be
if ($advancedOpts)
However even after this is corrected, submitting with the textarea empty results in the database not being updated, although the pxe menu file is updated.
Omitting line 479 means that the extra menu items are removed from both the database and the pxe menu.
If you leave the line in you would need to include lines 480 to 484 in the if statement, however this would mean that you couldn’t remove the extra items.
Hope this makes sense.

[Tom Elliott]

I think I know what you’re saying.

I made a typo, sorry quick implementation before I had to go to the doctors.

I understand to that the if means it only updates the information if there’s data in the text area. There may be times we don’t care about the data, so removing the if statement is probably the more logical choice.

[Tom Elliott]

r1199 released to fix that.

Sorry about the oversight.

[jbsclm]

Thanks.
Just one more thing, can you increase the height of the textarea box, currently set at 5, which makes it a pain when we have several extra menu items.
It is line 423, change rows=“5” to rows=“25”;
Other than that the code looks OK, I’ll test properly tomorrow.

[Tom Elliott]

Does your text area allow you to make the size larger with click and drag?

I don’t mind adding the extra lines, that’s too easy of a fix, but layout wise it make the page much longer than necessary.

[jbsclm]

Aha, I hadn’t realised you could resize it.
5 just fits the capone extras in, with resize it will be OK.
We have capone plus about 6 other items, at 0.32 it is a real pain to add them in, but then again perhaps I missed that it could be resized as well.
We started on 0.29 I think, perhaps I just assumed it hadn’t changed since them.
It will be OK left at 5.

Thanks

[jbsclm]

Pxe boot menu configuration page seems to work fine now thanks.
I checked on 0.32, it wasn’t resizable, I just hadn’t noticed the change to box at 0.33b

Thanks again.

[Tom Elliott]

r1200 released.

Adds delay and display of what the partitions are set after mbr/gpt generates the partition tables. Adds image name lookup on task search. Fixes the padding issue on the progress bar. Updates the TomElliott.config to 3.13.2 setup.

[Tom Elliott]

r1201 and r1202 released.

r1201 uses partclone.imager for raw image formats in mps and mpa imaging. This way, the partclone.restore actually works if an image had to be dd copied.

r1202 adds Storage Node elements to the Location Plugin stuff. Adds the same to the GroupManagementPage, HostManagementPage and LocationManagementPage. I have not added the host to the location stuff yet, but that will be in due time. Word of caution, if you have the location plugin enabled and you register a host, it will be required to enter a location for that host. If you don’t it will cause issues for the moment. I haven’t entered this in yet. So for the mean time, just be cognizant of this.

[Tom Elliott]

r1203 released to add some fixes to the Location Plugin.

Right now, my logic is:

Location To Group, select all storage nodes within that group. May not work right away as it checks for all storage nodes in the system, will need to add checking against the groups.

[Tom Elliott]

r1204 and 1205 released.

More modifications to Location stuffs. r1204 moved the location element to above host/group kernel items. Fixed typo for the add host location portion. Adds checking if the node is of a different storage group, it will change the group id to that of the node’s so things still work.

r1205 fixed issue in generating a new location. Needed to verify if storagenode was being set then check the group id and change it as necessary. This is only valid on the Adding a location. Need to add element when editing to only get the storage nodes within the specified group.

[Albatros]

I Hey,

I updated to revision 1205 and tested the deploy of the (new uploaded) image again. The init.gz has been replaced. Fog shows me
Listing of recognized partitions:
/dev/sda1 (C: partition), /dev/sda2 (extended partition, contains /dev/sda5 and /dev/sda6)
Partlcone starts and then it exits with “error exit” for both partitions and fog shows me again "no such file or directory /dev/sda1.
Starting the task again, partclone and fogs then works fine.

Do you think it would help to reinstall ubuntu?

[Tom Elliott]

No,

I’ve been trying to replicate the issues you’re seeing as I’m just not seeing it. That’s part of why I added the output of what partitions it thinks it has. The partitions you’re seeing are what’s created directly after the MBR or GPT tables are generated. My question about this issues though, is the BIOS set to SecureBoot and UEFI? And the OS is installed as MBR? I might think about, basically, righting the MBR/GUID tables twice and still outputting the partitions. This might help out with what we’re seeing.

[Albatros]

I use VirtualBox for testing and there I have no UEFI activated. The only thing that I do is, I clean the disk with gparted, removing all partitions.

[Tom Elliott]

Well,

I added sgdisk -Z which removes all partitions (GPT or MBR) and mbr data before “installing” the new partition tables.

[Tom Elliott]

I think I found the issue. I’m a dumb*** lol.

Basically, I used copy paste which by itself is fine. Except the line that’s supposed to remove the partitioning tables for MPS tasks was:

[code]sgdisk -Z $disk >/dev/null[/code]

The problem with this is that it works perfectly with MPA format because I have a variable called Disk. in MPS it only needs to worry about the current hard disk.

So I’m uploading right now.

r1206 should fix the mbr issue. Maybe it’ll work properly now? Please test and let me know. Sorry about that over sight. It’s only piece of code to look through 400 lines so I hope you’ll understand my mistake there.

[Tom Elliott]

r1207 released.

I was finally able to replicate the error exit issue described above.

My systems would work, as far as I could tell, because the partition tables weren’t truly changed on my systems.

So I completely wiped my drive and tried again, finally able to replicate the issue. It looks like the first iteration the partition table doesn’t actually get written.

So the interim fix is to add the fdisk command to simply write the tables to the disk.

[Troye Johnson]

hey question for you tom is there any way to inject items into the image a addon-image if you will?

[Tom Elliott]

Not easily, though I’ve heard of people doing this kind of thing with partclone images, I’ve never done this myself. Theoretically it is possible with partclone, but I don’t know how to do it myself.

[Troye Johnson]

I will look into this I think it would be a great addition to be able to do this. it would avoid having to take an image before sysprepring or what not and it would just allow us to add to the image.