1.5.4.8 to 1.5.9 : snapins dosen't work anymore

[Jonathan Cool]

Hi everybody,

I used FOG 1.5.4.8 for a while to deploy snapins sucessfully using a NAS as node.

After upgrade to 1.5.9 (to fix a printers management missing INF field), snapins doesn’t work anymore …

I setup a new server and import database.

I created a new snapin and tried to deploy it on a workstation …and it’s failed.

I’m not sur but i think this line is wrong : “15/03/2021 13:23:31 Middleware::Communication Download: http://NASIP//fog/service/snapins.file.php?mac=D8:9E:F3:48:0C:2E&taskid=3946”
Why Fog client tried to download snapins.file.php on NAS instead of FOG Server ?
Have you a quickfix for this issue or do we need to update to 1.6 stable ?

snap OK sur FOG 1.5.4.8 avec client 0.11.16

------------------------------------------------------------------------------
 15/03/2021 15:20 Client-Info Client Version: 0.11.16
 15/03/2021 15:20 Client-Info Client OS:      Windows
 15/03/2021 15:20 Client-Info Server Version: 1.5.4.8
 15/03/2021 15:20 Middleware::Response Success
 15/03/2021 15:20 SnapinClient Running snapin netlogonTx64
 15/03/2021 15:20 Middleware::Communication Download: http://FOGip1548/fog/service/snapins.file.php?mac=50:XX:4C:XX:67:XX||00:00:00:00:00:00:00:E0|00:00:00:00:00:00:00:E0&taskid=3938
 15/03/2021 15:20 SnapinClient C:\Program Files (x86)\FOG\tmp\netlogonTx64.zip
 15/03/2021 15:20 SnapinClient Processing SnapinPack netlogonTx64.zip
 15/03/2021 15:20 SnapinClient Extracting SnapinPack
 15/03/2021 15:20 Bus Emmiting message on channel: Notification
 15/03/2021 15:20 SnapinClient Starting snapin
 15/03/2021 15:20 SnapinClient Snapin finished
 15/03/2021 15:20 SnapinClient Return Code: 0
 15/03/2021 15:20 Bus Emmiting message on channel: Notification
 15/03/2021 15:20 Middleware::Communication URL: http://FOGip1548/fog/service/snapins.checkin.php?taskid=3938&exitcode=0&mac=50:9A:4C:02:67:44||00:00:00:00:00:00:00:E0|00:00:00:00:00:00:00:E0&newService&json
------------------------------------------------------------------------------

snap NOK sur FOG 1.5.9 avec client 0.12.0

------------------------------------------------------------------------------
 15/03/2021 13:23:31 Client-Info Client Version: 0.12.0
 15/03/2021 13:23:31 Client-Info Client OS:      Windows
 15/03/2021 13:23:31 Client-Info Server Version: 1.5.9
 15/03/2021 13:23:31 Middleware::Response Success
 15/03/2021 13:23:31 SnapinClient Running snapin wapt_agent
 15/03/2021 13:23:31 Middleware::Communication Download: http://NASIP//fog/service/snapins.file.php?mac=D8:9E:F3:48:0C:2E&taskid=3946
 15/03/2021 13:23:32 Middleware::Communication ERROR: Could not download file
 15/03/2021 13:23:32 Middleware::Communication ERROR: La connexion sous-jacente a été fermée : Une erreur inattendue s'est produite lors de l'envoi.
 15/03/2021 13:23:32 SnapinClient C:\Program Files (x86)\FOG\tmp\wapt_agent.zip
 15/03/2021 13:23:32 Middleware::Communication URL: http://FOGip159/fog/service/snapins.checkin.php?taskid=3946&exitcode=-1&mac=D8:9E:F3:48:0C:2E&newService&json
------------------------------------------------------------------------------

[Sebastian Roth]

@jonathan-cool said in 1.5.4.8 to 1.5.9 : snapins dosen't work anymore:

Have you a quickfix for this issue or do we need to update to 1.6 stable ?

Not sure if there is a quick fix. I will take a look at the code when I have a bit more time later on. Please don’t update to 1.6, it’s not a stable version.

What does your setup look like? On your FOG master node the NAS is configured as storage, right? Any other storages defined?

[Jonathan Cool]

@sebastian-roth said in 1.5.4.8 to 1.5.9 : snapins dosen't work anymore:

What does your setup look like? On your FOG master node the NAS is configured as storage, right? Any other storages defined?

There is the defaultMember : not used.
There are 4 NAS for 4 differents geographic locations used to imaging (capture and deploy images) and for deploy snapins. NAS are not defined as Master Storage …

[Sebastian Roth]

@jonathan-cool said in 1.5.4.8 to 1.5.9 : snapins dosen't work anymore:

There are 4 NAS for 4 differents geographic locations used to imaging

Ok, that information is key!

We did fix an issue between FOG 1.5.8 and 1.5.9 where snapins would not be pulled from the right location in earlier versions of FOG: https://github.com/FOGProject/fogproject/commit/d0162c82191a2f53404683481fab7443f5f0a36c

So the behavior you used in your setup to have NAS as storages (not fully featured storage nodes) is now broken because we fixed the issue.

The quick fix is to remove those lines in /var/www/html/fog/lib/client/snapinclient.class.php that were added to fix the issue (see github link above).

I am not sure about the long term solution. Probably you can’t host PHP (and the snapins) on your NAS!? Can you setup full storage nodes in all four locations (each can still use the NAS as storage)? Though this would make your setup more complex and cost resources.

[Jonathan Cool]

@sebastian-roth
Wahou ! Funny things !
So … all location use NAS as storage for images.
I’m the only one to use snapins.
Can i use the DefaultMember (Auto generated fog nfs group member) to store snapins ? I think, it’s the simple way … no ?

[Sebastian Roth]

@Jonathan-Cool I suppose your hosts are assigned to the NFS storages reside so they pull the image from that local NFS. I am not aware of an option in FOG to tell it to load snapins from the master node only. As I said there was a bug in the older FOG version that made it work like you need it.

I will have to take a closer look at the code again to see if we can add this as an option.

As I said, you can quickly edit the mentioned PHP file to get the old behavior back.

[Jonathan Cool]

@sebastian-roth I not sure if i understand what you said. If i recreate snapins on the DefaultMember location (on the server indeed), i could deploy them on my hosts whatever her OS image location, isn’t ?
My location is clos to the server. For me, the distance is not a problem in this case.

[Sebastian Roth]

@Jonathan-Cool You use the location plugin and your hosts are set to be on one or the other location (host settings), right? So a host deploying a snapin will try to pull that from the storage belonging to that location.

[Jonathan Cool]

@sebastian-roth
I don’t use the plugin location !
I haven’t enable the plugins in FOG !
But i just saw a video by @Wayne-Workman (thank to him) to understood your answer.
Very interessting feature …
So, to answer you : nope, i never used plugin ! a
I only created 4 storage groups and 4 storage nodes (one per group) and that’s all.
All NAS are on the same subnetwork (10.10.7.xx).

[Sebastian Roth]

@jonathan-cool said in 1.5.4.8 to 1.5.9 : snapins dosen't work anymore:

So, to answer you : nope, i never used plugin ! a
I only created 4 storage groups and 4 storage nodes (one per group) and that’s all.
All NAS are on the same subnetwork (10.10.7.xx).

Oh well, I got that wrong the whole time, sorry for that. Well then you should be able to achieve what you want by re-creating the snapin on your master node (Default storage group)., yes.

In your case all the snapins should be existing on the master node already (as you have no other full storage nodes). In this case you might be able to just change the Storage Group in each snapins’ settings.

[Jonathan Cool]

@sebastian-roth I finally used the downgrade method … (remove lines from snapinclient.class.php) and it’s works again

So, if i upgrade FOG version later, i will need to remove lines again ?

[Sebastian Roth]

@jonathan-cool said in 1.5.4.8 to 1.5.9 : snapins dosen't work anymore:

So, if i upgrade FOG version later, i will need to remove lines again ?

Yes, as it is expected behavior to load snapins from the node it was uploaded to.

[Jonathan Cool]

@sebastian-roth Ok !
Many thank for your precisous time. I have learned many thinks with your answers !