Is the FOG installer supposed to ask for an image storage location?

[mparlette]

@loosus456
[root@localhost bin]# cat installfog.sh | grep /images
storageLocation=“/images”
echo -n " * What is the storage location for your images directory? (/images) "
[[ -z $storageLocation ]] && storageLocation=“/images”
while [[ ! -d $storageLocation && $storageLocation != “/images” ]]; do
echo -n " * Please enter a valid directory for your storage location (/images) "
[[ -z $storageLocation ]] && storageLocation=“/images”

[A Former User]

This post is deleted!

[mparlette]

@loosus456
so running it /installfog.sh did not ask you? ok. running as root? otherwise I am not sure.

[Tom Elliott]

@mparlette you can set the location inline with
storageLocation=“/home/images” ./installfog.sh -y

[Tom Elliott]

@loosus456 it only asks if the location is specified before install and the location is not found.

By default, it will choose /images

[A Former User]

@Tom-Elliott Could you guys change it to always ask? I’ve seen enough posts on here alone about it that it seems like people expect it to.

In any case, when I tried this:

storageLocation=/newpath/to/location storageLocationCapture=/newpath/to/location/dev ./installfog.sh -y

I got the endless loop about the network interfaces.

[Tom Elliott]

@loosus456 There’s a few posts, but it’s far from an expectation, and there are ways to set it up already available by using the storageLocation and storageLocationCapture elements. The idea for the installer is to make it easier to get up and running.

As for the issue with the network interfaces, I’m guessing you’re trying to run the installer from the master branch? I ask this as it was found and I believe fixed in dev-branch (which will soon become master). Would you mind switching to the dev-branch and see if the issue is still present?

[A Former User]

This post is deleted!

[Sebastian Roth]

@loosus456 said:

I believe I actually used the dev-branch when I installed it. Just to verify, that is 1.5.5.3, right?

Yes that should be dev-branch. I will see if I can replicate the infinite loop issue when specifying the variables as you did.

Beside that I am wondering why ther is so much need to move the location to a different place?! One of Linux great filesystem features is that you can mount storage devices/partitions pretty much anywhere in the filesystem tree. So instead of having your images disk/partition mounted to /newpath/to/location just mount it in /images and everything else will fall in place. I am sure there might be good reasons not to do so and I am open to discuss this!

[A Former User]

This post is deleted!

[Sebastian Roth]

@loosus456 said in Is the FOG installer supposed to ask for an image storage location?:

By that same logic, I could say, “one of the great features of install scripts is that you can ask everything upfront so that end users don’t have to change anything later.”

I won’t discuss this!

See I don’t want to bully you on this. It’s just that I have other things to do than argue about why a installer should be this or the other way. If you think it should then why don’t you implement the fix yourself and post a pull request on github. We’ll happily add that to the official code.

[A Former User]

This post is deleted!

[Tom Elliott]

@loosus456

I understand what you’re requesting, and I think @Sebastian-Roth understands as well.

I’m not saying we shouldn’t or couldn’t be asking the storage location, just that there are ways to do what people want even if it’s not blatantly obvious. That’s why we’re here. To help people do what they want and show how to do so. Even if it could be handled in a better way.

Please understand that trying to code for every potential question and option is nearly impossible and in many cases will appease some and disgrace others regardless of the optional route chosen.

We are a very small development team. Trying to dedicate time for some things can be hard. That’s the brunt of what @Sebastian-Roth was trying to say, I truly believe.

I don’t think he is attempting to hurt anyone’s feelings. He’s just trying to say, if you (generalized to mean anybody I believe) feel something should be added, try to add it and make a pull request. We are often working with people to implement new items and fix bugs from others who have added suggestions and code.