• Recent
    • Unsolved
    • Tags
    • Popular
    • Users
    • Groups
    • Search
    • Register
    • Login

    Dell Precision Tower 5820 - FlexBay MiniSAS PCIe NVMe SSD not recognized

    Scheduled Pinned Locked Moved
    Hardware Compatibility
    9
    124
    49.3k
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • george1421G
      george1421 Moderator @hlalex
      last edited by

      @hlalex Very nice. I’m happy to see where the kernel is at, at the moment (its not currently working as you need it, but its close. I’ve also been able to address a few other issues not related to your issue).

      acpi PNP0A08:02: _OSC: OS supports [ExtendedConfig ASPM ClockPM Segments MSI]
acpi PNP0A08:02: _OSC: platform does not support [PME AER]
acpi PNP0A08:02: _OSC: OS now controls [PCIeHotplug PCIeCapability]


pciehp 0000:b2:02.0:pcie004: Slot(12-1): Power fault

      As soon as I get the above bits worked out to have them show in the FOS kernel, we should have access to that nvme drive. This is the step we were at just before the kernel got switched to 32 bit mode. Let me research these and I’ll come back with a ‘K’ release.

      Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

      1 Reply Last reply Reply Quote 1
      • S
        Sebastian Roth Moderator
        last edited by

        You guys are doing an awesome job here! Keep it up!

        Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

        Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

        1 Reply Last reply Reply Quote 0
        • george1421G
          george1421 Moderator
          last edited by george1421

          Version K has been posted. This one adds PCIe DMA support. We are getting very close to the config that was blowing up before where the kernel switched to 32 bit.

          Not related, but I added USB-C support to this kernel for those devices that hide behind it like network adapters on usb-c docks.

          Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

          H 2 Replies Last reply Reply Quote 1
          • H
            hlalex @george1421
            last edited by

            @george1421 That’s a great addition, especially with all the new devices with USB-C (these 5820s have 2 front C ports).
            Here are logs from Rev K:

            • bzImage41713k.log
            • bzImage41713k_lshw.log
            1 Reply Last reply Reply Quote 0
            • H
              hlalex @george1421
              last edited by

              @george1421 version L logs:

              • bzImage41713l.log
              • bzImage41713l_lshw.log
              george1421G 1 Reply Last reply Reply Quote 0
              • george1421G
                george1421 Moderator @hlalex
                last edited by

                @hlalex Well I’m down to researching this error:

                [    3.638397] nvme nvme0: failed to set APST feature (-19)

                I roughly have equivalency between Fedora Core 27 (4.13.9) and FOS (4.17.13) The nvme device is being seen by the kernel, but it can’t mount it at the moment.

                Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                H 1 Reply Last reply Reply Quote 0
                • H
                  hlalex @george1421
                  last edited by

                  @george1421 Found a few references to this error:

                  https://bugs.archlinux.org/task/57331

                  https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1678184

                  https://forums.lenovo.com/t5/ThinkPad-T400-T500-and-newer-T/NVMe-APST-problem-controller-is-down/td-p/3847511

                  http://lists.infradead.org/pipermail/linux-nvme/2017-February/008008.html

                  it looks like the variable to set is nvme_core.default_ps_max_latency_us=<some_number_here>

                  I tried setting it to 0, 250, and 300 according some those posts (using the “Host Kernel Arguments” option in the host record) and nothing seems to change.

                  1 Reply Last reply Reply Quote 0
                  • S
                    Sebastian Roth Moderator
                    last edited by Sebastian Roth

                    @george1421 @hlalex

                    nvme nvme0: failed to set APST feature (-19)

                    That -19 is usually means “No such device” (reference). Very strange.

                    In that arch linux bug report there are CONFIG_PCIEASPM_... kernel configs mentioned. Had a look at those yet? @george1421

                    What I was just thinking: Maybe Fedora has some special NVME patch included in their kernel that we don’t know about yet. Has anyone ever looked into the full Fedora kernel patchset?

                    EDIT: Not sure but that might be the one: https://git.kernel.org/pub/scm/linux/kernel/git/jwboyer/fedora.git/snapshot/fedora-kernel-4.13.9-300.fc27.tar.gz

                    EDIT2: Ok, sorry. This seems to be the full fedora kernel code. Anyone keen to create a diff to a vanilla kernel with that?

                    Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                    Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                    H george1421G 2 Replies Last reply Reply Quote 0
                    • H
                      hlalex @Sebastian Roth
                      last edited by

                      @sebastian-roth I just tested both options as kernel arguments and nothing seems to have changed.

                      I also tried the pcie_aspm.policy=powersave to no avail.

                      Let me know and I can try to post some logs before I have to punch out.

                      1 Reply Last reply Reply Quote 0
                      • george1421G
                        george1421 Moderator @Sebastian Roth
                        last edited by

                        @sebastian-roth The config parameter CONFIG_PCIEASPM_POWER_SUPERSAVE is currently not set.

                        I’ll take a peek at the patch and see if there is anything helpful. Its so close to working (at least dmsg wise). I’d hate to give up now…

                        Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                        1 Reply Last reply Reply Quote 0
                        • S
                          Sebastian Roth Moderator
                          last edited by

                          @george1421 Found this in the diff… no idea if that could be related:

                          diff -Nur linux-4.13/drivers/nvme/host/pci.c fedora-kernel-4.13.9-300.fc27/drivers/nvme/host/pci.c
--- linux-4.13/drivers/nvme/host/pci.c  2017-09-03 22:56:17.000000000 +0200
+++ fedora-kernel-4.13.9-300.fc27/drivers/nvme/host/pci.c       2017-10-23 22:25:50.000000000 +0200
@@ -93,7 +93,7 @@
        struct mutex shutdown_lock;
        bool subsystem;
        void __iomem *cmb;
-       dma_addr_t cmb_dma_addr;
+       pci_bus_addr_t cmb_bus_addr;
        u64 cmb_size;
        u32 cmbsz;
        u32 cmbloc;
@@ -1218,7 +1218,7 @@
        if (qid && dev->cmb && use_cmb_sqes && NVME_CMB_SQS(dev->cmbsz)) {
                unsigned offset = (qid - 1) * roundup(SQ_SIZE(depth),
                                                      dev->ctrl.page_size);
-               nvmeq->sq_dma_addr = dev->cmb_dma_addr + offset;
+               nvmeq->sq_dma_addr = dev->cmb_bus_addr + offset;
                nvmeq->sq_cmds_io = dev->cmb + offset;
        } else {
                nvmeq->sq_cmds = dma_alloc_coherent(dev->dev, SQ_SIZE(depth),
@@ -1517,7 +1517,7 @@
        resource_size_t bar_size;
        struct pci_dev *pdev = to_pci_dev(dev->dev);
        void __iomem *cmb;
-       dma_addr_t dma_addr;
+       int bar;
 
        dev->cmbsz = readl(dev->bar + NVME_REG_CMBSZ);
        if (!(NVME_CMB_SZ(dev->cmbsz)))
@@ -1530,7 +1530,8 @@
        szu = (u64)1 << (12 + 4 * NVME_CMB_SZU(dev->cmbsz));
        size = szu * NVME_CMB_SZ(dev->cmbsz);
        offset = szu * NVME_CMB_OFST(dev->cmbloc);
-       bar_size = pci_resource_len(pdev, NVME_CMB_BIR(dev->cmbloc));
+       bar = NVME_CMB_BIR(dev->cmbloc);
+       bar_size = pci_resource_len(pdev, bar);
 
        if (offset > bar_size)
                return NULL;
@@ -1543,12 +1544,11 @@
        if (size > bar_size - offset)
                size = bar_size - offset;
 
-       dma_addr = pci_resource_start(pdev, NVME_CMB_BIR(dev->cmbloc)) + offset;
-       cmb = ioremap_wc(dma_addr, size);
+       cmb = ioremap_wc(pci_resource_start(pdev, bar) + offset, size);
        if (!cmb)
                return NULL;
 
-       dev->cmb_dma_addr = dma_addr;
+       dev->cmb_bus_addr = pci_bus_address(pdev, bar) + offset;
        dev->cmb_size = size;
        return cmb;
 }
@@ -1609,18 +1609,16 @@
        dev->host_mem_descs = NULL;
 }
 
-static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred)
+static int __nvme_alloc_host_mem(struct nvme_dev *dev, u64 preferred,
+               u32 chunk_size)
 {
        struct nvme_host_mem_buf_desc *descs;
-       u32 chunk_size, max_entries, len;
+       u32 max_entries, len;
        dma_addr_t descs_dma;
        int i = 0;
        void **bufs;
        u64 size = 0, tmp;
-       /* start big and work our way down */
-       chunk_size = min(preferred, (u64)PAGE_SIZE << MAX_ORDER);
-retry:
        tmp = (preferred + chunk_size - 1);
        do_div(tmp, chunk_size);
        max_entries = tmp;
@@ -1647,15 +1645,9 @@
                i++;
        }
 
-       if (!size || (min && size < min)) {
-               dev_warn(dev->ctrl.device,
-                       "failed to allocate host memory buffer.\n");
+       if (!size)
                goto out_free_bufs;
-       }
 
-       dev_info(dev->ctrl.device,
-               "allocated %lld MiB host memory buffer.\n",
-               size >> ilog2(SZ_1M));
        dev->nr_host_mem_descs = i;
        dev->host_mem_size = size;
        dev->host_mem_descs = descs;
@@ -1676,21 +1668,35 @@
        dma_free_coherent(dev->dev, max_entries * sizeof(*descs), descs,
                        descs_dma);
 out:
-       /* try a smaller chunk size if we failed early */
-       if (chunk_size >= PAGE_SIZE * 2 && (i == 0 || size < min)) {
-               chunk_size /= 2;
-               goto retry;
-       }
        dev->host_mem_descs = NULL;
        return -ENOMEM;
 }
 
-static void nvme_setup_host_mem(struct nvme_dev *dev)
+static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred)
+{
+       u32 chunk_size;
+
+       /* start big and work our way down */
+       for (chunk_size = min_t(u64, preferred, PAGE_SIZE * MAX_ORDER_NR_PAGES);
+            chunk_size >= PAGE_SIZE * 2;
+            chunk_size /= 2) {
+               if (!__nvme_alloc_host_mem(dev, preferred, chunk_size)) {
+                       if (!min || dev->host_mem_size >= min)
+                               return 0;
+                       nvme_free_host_mem(dev);
+               }
+       }
+
+       return -ENOMEM;
+}
+
+static int nvme_setup_host_mem(struct nvme_dev *dev)
 {
        u64 max = (u64)max_host_mem_size_mb * SZ_1M;
        u64 preferred = (u64)dev->ctrl.hmpre * 4096;
        u64 min = (u64)dev->ctrl.hmmin * 4096;
        u32 enable_bits = NVME_HOST_MEM_ENABLE;
+       int ret = 0;
 
        preferred = min(preferred, max);
        if (min > max) {
@@ -1698,7 +1704,7 @@
                        "min host memory (%lld MiB) above limit (%d MiB).\n",
                        min >> ilog2(SZ_1M), max_host_mem_size_mb);
                nvme_free_host_mem(dev);
-               return;
+               return 0;
        }
 
        /*
@@ -1712,12 +1718,21 @@
        }
 
        if (!dev->host_mem_descs) {
-               if (nvme_alloc_host_mem(dev, min, preferred))
-                       return;
+               if (nvme_alloc_host_mem(dev, min, preferred)) {
+                       dev_warn(dev->ctrl.device,
+                               "failed to allocate host memory buffer.\n");
+                       return 0; /* controller must work without HMB */
+               }
+
+               dev_info(dev->ctrl.device,
+                       "allocated %lld MiB host memory buffer.\n",
+                       dev->host_mem_size >> ilog2(SZ_1M));
        }
 
-       if (nvme_set_host_mem(dev, enable_bits))
+       ret = nvme_set_host_mem(dev, enable_bits);
+       if (ret)
                nvme_free_host_mem(dev);
+       return ret;
 }
 
 static int nvme_setup_io_queues(struct nvme_dev *dev)
@@ -2161,8 +2176,11 @@
                                 "unable to allocate dma for dbbuf\n");
        }
 
-       if (dev->ctrl.hmpre)
-               nvme_setup_host_mem(dev);
+       if (dev->ctrl.hmpre) {
+               result = nvme_setup_host_mem(dev);
+               if (result < 0)
+                       goto out;
+       }
 
        result = nvme_setup_io_queues(dev);
        if (result)

                          Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                          Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                          george1421G 2 Replies Last reply Reply Quote 0
                          • george1421G
                            george1421 Moderator @Sebastian Roth
                            last edited by george1421

                            @sebastian-roth Just to add in a bit more, looking at the relevant dmsg lines this is what I see

                            [    0.402292] pci 0000:b3:00.0: [1c5c:1527] type 00 class 0x010802
[    0.402308] pci 0000:b3:00.0: reg 0x10: [mem 0xfb500000-0xfb503fff 64bit]
[    0.503618] nvme nvme0: pci function 0000:b3:00.0
[    0.716693]  nvme0n1: p1 p2 p3 p4
[    3.638397] nvme nvme0: failed to set APST feature (-19)

                            If I understand it correctly the kernel is seeing the nvme disk because it knows its name of nvme0n1 and it see 4 partitions on the disk.

                            I wonder if the patch you found made it into the main stream code? Since FC27 is using 4.13.9 and we’re testing 4.17.13

                            Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                            1 Reply Last reply Reply Quote 0
                            • Tom ElliottT
                              Tom Elliott
                              last edited by

                              I’m hoping you guys get this figured out. Sorry been distant for the last couple weeks. Just started a new position so not a lot of time right now during the day.

                              Of note, Linux kernel is now in the 4.18 series. I’m going to be building a new kernel relatively shortly, just need time (probably this weekend.)

                              @george1421 Would you mind building a plain jane 4.18 based on the TomElliott.config? Don’t forget to do the patches:

                              https://wiki.fogproject.org/wiki/index.php?title=Build_TomElliott_Kernel#Additional_Patches

                              In particular the patches for:
                              mmc (The path used to be mmc/card/ is now mmc/core/) and scsi/storvsc (this is whats supposed to help with the mbr/gpt erasing issue).

                              I believe the e1000 patch was already fixed in 4.17 so we shouldn’t need to do anything, but you can open the and check.

                              Sorry I can’t be more useful right now.

                              Either way, awesome work guys.

                              Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                              Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                              Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                              george1421G 1 Reply Last reply Reply Quote 0
                              • george1421G
                                george1421 Moderator @Tom Elliott
                                last edited by

                                @tom-elliott said in Dell Precision Tower 5820 - FlexBay MiniSAS PCIe NVMe SSD not recognized:

                                Would you mind building a plain jane 4.18 based on the TomElliott.config? Don’t forget to do the patches:

                                Do you want 4.18 based on FOG standard configuration, or where I’m at with 4.17.13?

                                Either way, I probably should apply the additional patches to 4.17.13. Just as a side note, I didn’t see the patch for the slow GPT disk issue you mentioned a while ago. Do you have that info too?

                                Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                                Tom ElliottT 1 Reply Last reply Reply Quote 0
                                • Tom ElliottT
                                  Tom Elliott @george1421
                                  last edited by Tom Elliott

                                  @george1421 On the wiki page, that’s the storvsc portion of the additional patches.

                                  For understanding,

                                  If the page size is 4096, it’s supposed to do stuff. However, not all disks use a 4096 page size. This is noticed particularly when initializing/erasing mbr/gpt structures on a disk. It’s just strange, to me, that it only seems to be impacting Windows based installs. At least from what I’ve seen.

                                  Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG! Get in contact with me (chat bubble in the top right corner) if you want to join in.

                                  Web GUI issue? Please check apache error (debian/ubuntu: /var/log/apache2/error.log, centos/fedora/rhel: /var/log/httpd/error_log) and php-fpm log (/var/log/php*-fpm.log)

                                  Please support FOG if you like it: https://wiki.fogproject.org/wiki/index.php/Support_FOG

                                  1 Reply Last reply Reply Quote 1
                                  • george1421G
                                    george1421 Moderator @Sebastian Roth
                                    last edited by

                                    @sebastian-roth The kernel patch and diffs you found for 4.13 have been integrated into the mainstream code. I confirmed they were there in 4.17.13

                                    I’m going to rebuild with that config parameter you mentioned form that Arch post. I also integrated the patches from the FOG Wiki site. For now I think I’m going to stick with 4.17.13 for developing the kernel, I have a rule to never install a XX.0 release of anything (thank you Bill Gates).

                                    Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                                    1 Reply Last reply Reply Quote 1
                                    • george1421G
                                      george1421 Moderator
                                      last edited by

                                      I did recompile the 4.17.13 kernel with the powersave setting from the Arch article, plus FOG kernel patches and then added support for Microsoft Surface network adapter (patch info found here: https://forums.fogproject.org/topic/10943/surface-pro-4-registration-issues ). This kernel is ‘M’ release. Please test it out.

                                      Please help us build the FOG community with everyone involved. It's not just about coding - way more we need people to test things, update documentation and most importantly work on uniting the community of people enjoying and working on FOG!

                                      H 3 Replies Last reply Reply Quote 0
                                      • H
                                        hlalex @george1421
                                        last edited by

                                        @george1421 version M logs:

                                        • bzImage41713m.log
                                        • bzImage41713m_lshw.log
                                        1 Reply Last reply Reply Quote 1
                                        • H
                                          hlalex @george1421
                                          last edited by hlalex

                                          @george1421 FlexBay Parts:

                                          414-BBBV : PCIe SSD (Front PCIe FlexBay)
                                          Part Number Quantity Description
                                          5G90D 1 INFORMATION, FRONT, PERIPHERAL COMPONENT INTERCONNECT EXPRESS , SOFTWARE SUPPORT DISKETTE, BOOT

                                          401-ABJT : M.2 512GB PCIe NVMe Class 40 S olid State Drive
                                          Part Number Quantity Description
                                          XMW6J 1 SSDR, 512G, P34, 80S3, HYNIX, PC401

                                          400-AVDR : Dell M.2 carrier
                                          Part Number Quantity Description
                                          66XHV 1 ASSEMBLY, DRIVE, BAY (DRIVE BAY), M.2, MODULE

                                          1 Reply Last reply Reply Quote 0
                                          • H
                                            hlalex @george1421
                                            last edited by

                                            @george1421 Ok, got some data from windows device manager for the FlexBay drive:

                                            PCI Memory Controller [ this was an uninitialized device, figured it best to include as it is a PCI device but probably not relevant ]

                                            • PCI\VEN_8086&DEV_A2A1&SUBSYS_07381028&REV_00

                                            Everything below l pertains to the M.2 connected to the FlexBay
                                            Disk drive
                                            Device instance path

                                            • SCSI\DISK&VEN_NVME&PROD_PC401_NVME_SK_HY\5&1A7BC20F&0&000000

                                            HW IDs

                                            • SCSI\DiskNVMe____PC401_NVMe_SK_hy3E00
                                            • SCSI\DiskNVMe____PC401_NVMe_SK_hy
                                            • SCSI\DiskNVMe____
                                            • SCSI\NVMe____PC401_NVMe_SK_hy3
                                            • NVMe____PC401_NVMe_SK_hy3
                                            • GenDisk

                                            Status

                                            • 0180200A
                                            • DN_DRIVER_LOADED
                                            • DN_STARTED
                                            • DN_DISABLEABLE
                                            • DN_NT_ENUMERATOR
                                            • DN_NT_DRIVER

                                            Class Guid

                                            • {4d36e967-e325-11ce-bfc1-08002be10318}

                                            Device stack

                                            • \Driver\partmgr
                                            • \Driver\Disk
                                            • \Driver\EhStorClass
                                            • \Driver\stornvme

                                            Driver node strong name

                                            • disk.inf:6d166ee9677c725c:disk_install.NT:10.0.16299.371:GenDisk

                                            0_1534434310029_general.JPG
                                            0_1534434324187_driver.jpg
                                            0_1534434336379_events.JPG

                                            1 Reply Last reply Reply Quote 0
                                            • 1
                                            • 2
                                            • 3
                                            • 4
                                            • 5
                                            • 6
                                            • 7
                                            • 3 / 7
                                            • First post
                                              Last post

                                            152

                                            Online

                                            12.0k

                                            Users

                                            17.3k

                                            Topics

                                            155.2k

                                            Posts
                                            Copyright © 2012-2024 FOG Project