Win7x64 : Golden Image : partitions problems ... again


  • Developer

    @Quazz said:

    I’m guessing the encoding gets messed up somewhere along the road

    Exactly what is happening. I don’t fancy trying to get the encodings right because this will break sooner than later again.

    @Jonathan-Cool said:

    I tried your patch on the VM, upload the new image and tried a new download … it’s didn’t work.

    Can you please do another test, same way but do a debug upload and when you get to the shell run grep label /usr/share/fog/lib/funcs.sh, take a picture of the screen and post here. Just so we get an idea if the patching really works.



  • Hm, we are close to find the issue … I can confirmed … when i renamed the system partition in my Golden Image, the reserved partition has the good size after a deploy on a o7010 …
    So, the intuition was good … !

    Screenshot on o7010 : https://drive.google.com/file/d/1btji1AQSUx7SmOQU5JsplMbENy6DFl1u/view?usp=sharing


  • Moderator

    @Sebastian-Roth Just wondering, but would it be possible to use unicode here for the accented characters?

    edit: Just tested and no…

    Though I wonder, can we just use the characters directly? My small test seems to think so. Which means:

    if [[ $label =~ [Rr][Ee][Ss][Ee][Rr][Vv][Ee][Dd] || $label =~ [Rr][�~Ié][Ss][�~Ié][Rr][Vv][�~Ié] ]]; then
    

    Can be rewritten and simplified to:

    if [[ $label =~ [Rr][EeÉé][Ss][EeÉé][Rr][Vv][EeÉé][Dd]? ]]; then
    

    I’m guessing the encoding gets messed up somewhere along the road �~Ié likely simply means é. Don’t know how or when this happens/happened, but that’s my guess (I’ve seen this before trying to sort out data in different languages)



  • You totally right …
    I will try the download with the modified name partition.
    If it’s works, we can realize new tests with the “sed” command hack to permanently fix this issue for all french people.


  • Moderator

    @Jonathan-Cool That should straight up work, but ofc doesn’t really help us prevent this problem in the future for new people.



  • Hi,

    I’m back after few off days …

    I tried your patch on the VM, upload the new image and tried a new download … it’s didn’t work.

    I tried to play with backslashes and no more sucess …

    BUT, i have an other idea :

    • run the VM
    • go to the Disks Management tool
    • right click on the “Partition réservé au système”
    • rename this damn partition to “System Reserved” (<-- it is the right US/english name ?)
    • upload the image on FOG
    • try a new DL on client …

    What do you think about that idea ?


  • Developer

    @Jonathan-Cool said in Win7x64 : Golden Image : partitions problems ... again:

    but if i really understood, i do the debug upload task on my VM ?

    Yes, exactly what I meant! :-)

    Ohh dang, I forgot the patch for fog.upload. So please edit your /images/dev/postinitscripts/fog.postinit again and make it look like this:

    #!/bin/bash
    ## This file serves as a starting point to call your custom pre-imaging/post init loading scripts.
    ## <SCRIPTNAME> should be changed to the script you're planning to use.
    ## Syntax of post init scripts are
    #. ${postinitpath}<SCRIPTNAME>
    
    sed -i -e "s#\[Rr\]\[Ee\]\[Ss\]\[Ee\]\[Rr\]\[Vv\]\[Ee\]\[Dd\]#RM-CM-\\\)servM-CM-\\\)#gi" /bin/fog.upload
    sed -i -e "s#\[Rr\]\[Ee\]\[Ss\]\[Ee\]\[Rr\]\[Vv\]\[Ee\]\[Dd\]#RM-CM-\\\)servM-CM-\\\)#gi" /usr/share/fog/lib/funcs.sh
    

    Hopefully I got it all right this time and it will upload the image for you in a way that you don’t have to change p1.fixed_size_partitions manually anymore.



  • @Sebastian-Roth said in Win7x64 : Golden Image : partitions problems ... again:

    Save the file and boot up your client with a debug upload task

    i understand your way and your test … but if i really understood, i do the debug upload task on my VM ? Because you said “upload task” …


  • Developer

    @Jonathan-Cool Ok, should have listened to my intuition - those character encoding things are just a nightmare.

    I think it’s wise to step back and try the route mentioned earlier. Edit /images/dev/postinitscripts/fog.postinit on your FOG server and add a single line to the end of that script so it would look like this:

    #!/bin/bash
    ## This file serves as a starting point to call your custom pre-imaging/post init loading scripts.
    ## <SCRIPTNAME> should be changed to the script you're planning to use.
    ## Syntax of post init scripts are
    #. ${postinitpath}<SCRIPTNAME>
    
    sed -i -e "s#\[Rr\]\[Ee\]\[Ss\]\[Ee\]\[Rr\]\[Vv\]\[Ee\]\[Dd\]#RM-CM-\\\)servM-CM-\\\)#gi" /usr/share/fog/lib/funcs.sh
    

    You know, regular expressions are just a bit tricky and those triple backslashes really look confusing. But I kind of tested this and I am fairly sure this should work if you get it all right.

    Save the file and boot up your client with a debug upload task. When you get to the shell run fog and right after it said “Running post init scripts” you want to stop it for the moment (ctrl+c). Then check to see if the script did its work: grep label /usr/share/fog/lib/funcs.sh and you should see something like this:

                local label=$(getPartitionLabel "$part")
                if [[ $label =~ [Rr][Ee][Cc][Oo][Vv][Ee][Rr][Yy] ]]; then
                if [[ $label =~ RM-CM-\)servM-CM-\) || $label =~ [Rr][Éé][Ss][Éé][Rr][Vv][Éé] ]]; then
    # Gets the volume group name/label.
    # Get's volume labels from volume group.
    

    If your third line looks like this I would give it a try, just start the task again using the fog command. If it does not, play with the postinitscript and try again.



  • Hi !
    I ran a new debug task on a client …

    [Wed Sep 12 root@fogclient ~]# blkid -po udev $part | grep FS_LABEL
    blkid: The low-level probing mode requires a device
    
    
    [Wed Sep 12 root@fogclient ~]# blkid                               
    /dev/ram0: UUID="885cb2cc-e11f-4e88-8182-ee60a35f43d1" TYPE="ext2"
    /dev/sda1: LABEL="RM-CM-)servM-CM-) au systM-CM-(me" UUID="8E4C92C44C92A70D" TYPE="ntfs" PARTUUID="c91a5cff-01"
    /dev/sda2: LABEL="System" UUID="46E2941BE29410F3" TYPE="ntfs" PARTUUID="c91a5cff-02"
    

    On the 2nd command, we can see the very strange label of /dev/sda1 … !

    Edit : I deployed a classic image on o7010 and tried the same commands : same results … :

    [Wed Sep 12 root@fogclient ~]# blkid
    /dev/ram0: UUID="885cb2cc-e11f-4e88-8182-ee60a35f43d1" TYPE="ext2"
    /dev/sda1: LABEL="RM-CM-)servM-CM-) au systM-CM-(me" UUID="A27C916A7C9139CD" TYPE="ntfs" PARTUUID="3f61e1ac-01"
    /dev/sda2: LABEL="System" UUID="34C09543C0950BEC" TYPE="ntfs" PARTUUID="3f61e1ac-02"
    [Wed Sep 12 root@fogclient ~]# blkid -po udev $part | grep FS_LABEL
    blkid: The low-level probing mode requires a device
    
    

  • Developer

    @Jonathan-Cool Too bad to hear this has not worked for you! I remember having that weird feeling when this was added that those accents might cause an issue. Can you please do another debug session an run the following command: blkid -po udev $part | grep FS_LABEL

    Let’s see how the label looks like on your machine.



  • Hi !
    I’m back after the 1.5.4.8 update … and the issue is still there :(

    I tried to deploy my Golden Image on the 3 optiplex and i had the same results … very large reserved partition.

    I opened the fog.upload on a debug client task (ssh session) and checked the funcs.sh file :

                local label=$(getPartitionLabel "$part")
                if [[ $label =~ [Rr][Ee][Cc][Oo][Vv][Ee][Rr][Yy] ]]; then
                    echo "$(cat "$imagePath/d1.fixed_size_partitions" | tr -d \\0):${part_number}" > "$imagePath/d1.fixed_size_partitions"
                    echo " * Not shrinking ($part) recovery partition"
                    debugPause
                    return
                fi
                if [[ $label =~ [Rr][Ee][Ss][Ee][Rr][Vv][Ee][Dd] || $label =~ [Rr][�~Ié][Ss][�~Ié][Rr][Vv][�~Ié] ]]; then
                    echo "$(cat "$imagePath/d1.fixed_size_partitions" | tr -d \\0):${part_number}" > "$imagePath/d1.fixed_size_partitions"
                    echo " * Not shrinking ($part) reserved partitions"
                    debugPause
                    return
                fi
    
    

    I take a picture of the same file directly on screen … : https://drive.google.com/open?id=12wiSow0jfowtj85T0AI9NF_CvkH9eMyW

    What can i do to find the culprit ? Maybe it’s not a FOG problem but a problem during the Golden Image creation with Virtualbox ?



  • Thank you :)

    I wil try to update my fog server to 1.5.4 :)

    I will be back for the feedbacks :)


  • Developer

    @Jonathan-Cool I am not saying you need to update. Those threads explain how to modify the scripts (either manual or on the fly when booting).

    I just looked at the code again and seems like Tom actually added the French label: https://github.com/FOGProject/fos/blob/master/Buildroot/board/FOG/FOS/rootfs_overlay/usr/share/fog/lib/funcs.sh#L493

    So I would think if you update to 1.5.4 you should have this fixed.



  • Thank you for the answer !

    I have already saw theses topics ;)

    But … i’m on FOG 1.4.2 … i searched if newer version fix the label partition problem and i can’t found any annoncement to say that … Maybe i can update my FOG Server to the lastest … but i just want to be sure this issue has fixed …


  • Developer

    @Jonathan-Cool said in Win7x64 : Golden Image : partitions problems ... again:

    I need to edit the postinit file but, what i exactly do with this file ?

    Have you looked into this yet? George’s thread about this is pretty straight forward - that is, if you know a bit of shell scripting.

    If not you can still choose the other way and follow my advise here: https://forums.fogproject.org/post/96948


Log in to reply
 

394
Online

6.1k
Users

13.4k
Topics

126.4k
Posts